Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove helmet #653

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .yarnrc.yml
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
compressionLevel: mixed

plugins:
- checksum: 7930a64ba6239d4502df0204edda913788df1a9614a9056d23b53345d844f6f13526dae71c2be5282071502c3c077db7b1e97bcf019037db3ca35c737cd25b0c
path: .yarn/plugins/plugin-dedupe-on-install.cjs
spec: "https://raw.githubusercontent.com/ambar/yarn-plugin-dedupe-on-install/main/index.js"

packageExtensions:
react-plotly.js@*:
peerDependenciesMeta:
plotly.js:
optional: true

plugins:
- checksum: 7930a64ba6239d4502df0204edda913788df1a9614a9056d23b53345d844f6f13526dae71c2be5282071502c3c077db7b1e97bcf019037db3ca35c737cd25b0c
path: .yarn/plugins/plugin-dedupe-on-install.cjs
spec: "https://raw.githubusercontent.com/ambar/yarn-plugin-dedupe-on-install/main/index.js"
7 changes: 3 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"@matejmazur/react-katex": "^3.1.3",
"@mui/icons-material": "^6.3.1",
"@mui/material": "^6.3.1",
"@mui/system": "^6.1.0",
"@mui/system": "^6.3.1",
"fetch-suspense": "^1.2.2",
"katex": "^0.16.19",
"merge-sx": "^3.3.1",
Expand All @@ -38,7 +38,6 @@
"react": "^19.0.0",
"react-dom": "^19.0.0",
"react-error-boundary": "^5.0.0",
"react-helmet-async": "^2.0.5",
"react-is": "^19.0.0",
"react-plotly.js": "^2.6.0",
"react-portal-target": "^1.0.2",
Expand Down Expand Up @@ -73,11 +72,11 @@
"restructured": "^0.0.11",
"rollup": "^4.29.1",
"typescript": "^5.7.2",
"unplugin-fonts": "^1.1.1",
"unplugin-fonts": "^1.3.1",
"vite": "^6.0.5",
"vite-bundle-visualizer": "^1.2.1"
},
"packageManager": "yarn@4.5.3",
"packageManager": "yarn@4.6.0",
"lint-staged": {
"!(rawPosts)": "biome check --no-errors-on-unmatched --files-ignore-unknown=true --write"
}
Expand Down
5 changes: 1 addition & 4 deletions src/components/routes/App/index.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { useMemo } from 'react'
import { Helmet } from 'react-helmet-async'
import { PortalTarget } from 'react-portal-target'
import { Link, Navigate, Route, matchPath, useLocation } from 'react-router-dom'
import SlideRoutes from 'react-slide-routes'
Expand Down Expand Up @@ -79,9 +78,7 @@ const App = () => {

return (
<ThemeProvider theme={theme}>
<Helmet>
<title>phil.red</title>
</Helmet>
<title>phil.red</title>
<CssBaseline />
<ElevationScroll>
<AppBar
Expand Down
16 changes: 5 additions & 11 deletions src/components/routes/Blog/index.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import type { FC } from 'react'
import { Helmet } from 'react-helmet-async'
import { Navigate, Route, useParams } from 'react-router-dom'
import SlideRoutes from 'react-slide-routes'

Expand Down Expand Up @@ -60,23 +59,18 @@ const RoutedPost: FC = () => {
}
return (
<>
<Helmet>
<title>
{document.title}
{' – '}
Blog – phil.red
</title>
</Helmet>
<title>
{document.title}
{' – Blog – phil.red'}
</title>
<Markup doc={document} />
</>
)
}

const Blog = () => (
<>
<Helmet>
<title>Blog – phil.red</title>
</Helmet>
<title>Blog – phil.red</title>
<SlideRoutes animation="vertical-slide">
<Route index element={<Index />} />
<Route path=":year/:month/:day/:id" element={<RoutedPost />} />
Expand Down
5 changes: 1 addition & 4 deletions src/components/routes/Code/index.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { createElement } from 'react'
import { Helmet } from 'react-helmet-async'
import { isValidElementType } from 'react-is'

import Avatar from '@mui/material/Avatar'
Expand Down Expand Up @@ -110,9 +109,7 @@ const GitHubItems = () => (

const Code = () => (
<>
<Helmet>
<title>Code – phil.red</title>
</Helmet>
<title>Code – phil.red</title>
<List>
<ListItemLink
href="https://github.com/flying-sheep"
Expand Down
9 changes: 3 additions & 6 deletions src/main.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import './main.css'

import { StrictMode } from 'react'
import { createRoot } from 'react-dom/client'
import { HelmetProvider } from 'react-helmet-async'
import { BrowserRouter as Router } from 'react-router-dom'

import App from './components/routes/App'
Expand All @@ -19,11 +18,9 @@ document.addEventListener('DOMContentLoaded', () => {
const root = createRoot(elem)
root.render(
<StrictMode>
<HelmetProvider>
<Router>
<App />
</Router>
</HelmetProvider>
<Router>
<App />
</Router>
</StrictMode>,
)
})
Loading
Loading