-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: read config json from documents dir #478
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Open for discussion, I'd rather prefer a solution that is not strictly time-based since not everyone uses the FlightSim on a daily basis |
Yep, I see the point. I just want to keep the change as minimal as possible. Please check again, I've added another directories entries in the config which points to the old one. For me it's a good compromise :D Otherwise I would think it's too much. If we go with my original proposal, only people who ignore the update will have an issue with the "Resources" button in the installer. The configuration is supporting both. I would consider that acceptable. |
* feat: read config json from home dir * fix * use documents folder * fix: use correct import * fix: resources shortcut * revert unwanted change * enable temporary warning text for simbridge * fix: allow backwards compatibility * fix typo * fix: enable html rendering on addon description * fix: use old simbridge configuration automatically if new one not present * fix lint * fix typo --------- Co-authored-by: Saschl <[email protected]>
Needs flybywiresim/simbridge#121 to be released first.
Summary of Changes
Screenshots (if necessary)
Additional context
Discord username (if different from GitHub):