Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: read config json from documents dir #478

Merged
merged 15 commits into from
Oct 14, 2024
Merged

Conversation

Saschl
Copy link
Contributor

@Saschl Saschl commented Sep 30, 2024

Needs flybywiresim/simbridge#121 to be released first.

Summary of Changes

Screenshots (if necessary)

Additional context

Discord username (if different from GitHub):

@Saschl Saschl changed the title feat: read config json from home dir feat: read config json from documents dir Sep 30, 2024
Copy link
Member

@FoxtrotSierra6829 FoxtrotSierra6829 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grafik
In the about page, the html parsing is not implemented. Also, the fallback is missing for the resources folder which would be helpful to access to move the files before updating.

@Saschl
Copy link
Contributor Author

Saschl commented Oct 9, 2024

grafik In the about page, the html parsing is not implemented. Also, the fallback is missing for the resources folder which would be helpful to access to move the files before updating.

Fixed the first, thanks 👍 About the fallback: we could also split the installer-data PR into two.

  1. Only update the description to raise awareness -> installer works as before
  2. Update the path together with the simbridge release -> installer will open the new directory with the resources button

@FoxtrotSierra6829
Copy link
Member

Open for discussion, I'd rather prefer a solution that is not strictly time-based since not everyone uses the FlightSim on a daily basis

@Saschl
Copy link
Contributor Author

Saschl commented Oct 9, 2024

Open for discussion, I'd rather prefer a solution that is not strictly time-based since not everyone uses the FlightSim on a daily basis

Yep, I see the point. I just want to keep the change as minimal as possible. Please check again, I've added another directories entries in the config which points to the old one. For me it's a good compromise :D

Otherwise I would think it's too much. If we go with my original proposal, only people who ignore the update will have an issue with the "Resources" button in the installer. The configuration is supporting both. I would consider that acceptable.

image

@Saschl Saschl merged commit bf58f63 into master Oct 14, 2024
3 checks passed
@Saschl Saschl deleted the feature/move-to-home branch October 14, 2024 21:39
Saschl added a commit that referenced this pull request Oct 15, 2024
* feat: read config json from home dir

* fix

* use documents folder

* fix: use correct import

* fix: resources shortcut

* revert unwanted change

* enable temporary warning text for simbridge

* fix: allow backwards compatibility

* fix typo

* fix: enable html rendering on addon description

* fix: use old simbridge configuration automatically if new one not present

* fix lint

* fix typo

---------

Co-authored-by: Saschl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants