Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move to electron-vite for build, clean up CI #462

Merged
merged 24 commits into from
Aug 21, 2024

Conversation

Benjozork
Copy link
Member

@Benjozork Benjozork commented Mar 30, 2024

Summary of Changes

  • Entirely replaces webpack with electron-vite
  • Cleans up PR CI

@Benjozork Benjozork changed the title refactor: move to electron-vite for build refactor: move to electron-vite for build, clean up CI Apr 14, 2024
@brewers10
Copy link

Quality Assurance Tester Report

Discord: brewers_10
Object of testing: #462
Tier of Testing: 1
Date: 14/04/2024

Testing Process:
Installed installer
Installed stable versions of A32NX, B74S, KFBW and Simbridge. Simbridge loads perfectly fine and aircraft/scenery work with sim.

Negatives:
N/A

Testing Results:
Passed

Conclusions:
LGTM

Media:
N/A

src/renderer/index.tsx Outdated Show resolved Hide resolved
@alepouna
Copy link
Member

alepouna commented Apr 23, 2024

Quality Assurance Tester Report

Discord: alepouna
Object of testing: #462
Date: 23/04/2024

Testing Process:

  • Installed installer

Negatives:
Descriptions are missing from addons, 'Error' when hovering on already installed items.
image

Testing Results:
Not Passed

Console logs:
Spam of Sentry errors such as

index-CbxzvBJf.js:7930 Fetch API cannot load sentry-ipc://sentry-electron.scope/sentry_key. URL scheme "sentry-ipc" is not supported.
index-CbxzvBJf.js:7649 Sentry SDK failed to establish connection with the Electron main process.

  • Ensure you have initialized the SDK in the main process
  • If your renderers use custom sessions, be sure to set 'getSessions' in the main process options
  • If you are bundling your main process code and using Electron < v5, you'll need to manually configure a preload script

No other error logs.

@noonebling
Copy link

Quality Assurance Trainee Report

Discord : noonebling
Object of testing: #462
Tier of Testing : 1
Date : 24/04/2024

Testing Process:
Installed Installer.
Installed different versions of addons in the installer

Negatives:
Descriptions are missing in all addons
image

The slider bars in Settings page do not change appearance when kept to the right (On position)
image

Testing Results:
Not Passed

@alepouna
Copy link
Member

Quality Assurance Tester Report

Discord: alepouna
Object of testing: #462
Date: 27/04/2024

Testing Process:

  • Installed installer
  • Test various addons and updating
  • Test custom configs

Testing Results:
Passed

@Popespice
Copy link

Popespice commented Apr 28, 2024

Quality Assurance Tester Report

Discord : Popespice
Object of testing: #462
Tier of Testing : 1
Date : 28/4/2024

Testing Process:

  1. Deleted Appdata existing installer and supporting folder
  2. Installed new installer from PR build
  3. Opened Installer
  4. Navigate to Settings
  5. Click "third party licenses"
  6. Observe popup that states "requested file not found"

Negatives:
(Any issues, doubts. - type N/A if none are found)

Testing Results:
Not Passed

Conclusions:
Not working as expected

Media:
N.A

@alepouna
Copy link
Member

Quality Assurance Tester Report

Discord: alepouna
Object of testing: #462
Date: 22/08/2024

Testing Process:

  • Installed installer
  • Test install various addons (A32NX, big bertha, FSLTL, Salty) and updating. Test CDN and direct.
  • Test custom configs
  • Check 3rd party licenses page loads fine

Testing Results:
Passed

@Benjozork Benjozork merged commit 573c529 into master Aug 21, 2024
3 checks passed
Benjozork added a commit that referenced this pull request Aug 21, 2024
* initial commit

* fix: packaging

* fix: split settings into two to fix broken directory stuff

* chore: remove unneeded files

* chore: cleanup

* chore: cleanup

* fix: remove preload stuff

* ci: tweak pr workflows

* ci: try to fix cache

* build: re-add autoprefixer

* fix: rmdir

* chore: update some packages

* fix: track description not showing

* fix: toggle styling

* build: bump react-markdown to v8

* fix: license link font size

* build: fix generation of license file

* ci: tweaks

* refactor: change way third party licenses work

* fix: update vite and electron-vite to fix bundling issue

* chore: fix lint

* chore: fix package-lock.json

* fix: appdata

(cherry picked from commit 573c529)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants