feat(a380x/fms): Add (auto) step climbs; Allow CLB/DES constraint selection #9804

flogross89 · 2025-01-26T00:07:53Z

Fixes #9486

Summary of Changes

Adds step climbs to A380X.

Changes:

STEP ALTs tab of VERT REV page implemented
Interface to flight plan correctly integrated
Allow selection of CLB/DES constraint for SPD and ALT constraints
Add "auto step climb" QoL function
Add "ABOVE MAX FL" / "STEP DELETED" messages

Out of scope (i.e. not implemented):

Optimum step point (requires deeper FMS changes)
Subscriptions cleanup for pages other than VERT REV to be done in chore(a380x/mfd): Subscriptions overhaul #9807

Changelog will be added shortly before merge.

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

Load up cold&dark at airport, plan long enough flight (>3h) in Simbrief; Enable "Auto Step Climb" in EFB Realism Settings
Fill in FMS as per normal procedures
Insert step climbs or step descends (not too close to T/C or T/D, otherwise they'll get ignored)
Delete step climbs or descends (clear altitude and/or waypoint field), see whether that works
Enter step climb above max FL, should be ignored with "ABOVE MAX FL" message
Start flight, take-off, fast forward to cruise (sim rate can be increased)
When approaching S/C waypoint (at 20nm distance), the aircraft should display "STEP AHEAD" in the FMS message field. If Auto Step climb is enabled, the FCU alt should be automatically set to the new value, and CLB/DES should be engaged
Verify that step climbs or descends work as intended, with or without Auto Step Climbs enabled

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

Make sure you are signed in to GitHub
Click on the Checks tab on the PR
On the left side, find and click on the PR Build tab
Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

aadee9940 · 2025-01-26T01:01:34Z

Just a small question, does optimum step point take into account wind? Or just based on gross weight?
speaking of which wind import in the 380 would be nice :)

flogross89 · 2025-01-26T19:53:42Z

@aadee9940 In the real aircraft, winds are taken into account. However, the optimum step point calculation won't be implemented as part of this PR. Furthermore, wind import needs bigger adaptions to the FMS, so this will likely take some time.

BravoMike99 · 2025-01-27T21:13:55Z

Could you also hook up the "STEP DELETED" MFD message? Should be as simple as listening to the A32NX_FM_VNAV_TRIGGER_STEP_DELETED var. It may not handle all the A380 specific cases but it handles the sequencing one at least.

flogross89 · 2025-01-27T22:07:12Z

Could you also hook up the "STEP DELETED" MFD message? Should be as simple as listening to the A32NX_FM_VNAV_TRIGGER_STEP_DELETED var. It may not handle all the A380 specific cases but it handles the sequencing one at least.

Good point, thanks! Just pushed the changes.

BlueberryKing

Good work 💯

fbw-a380x/src/systems/instruments/src/MFD/FMC/FlightManagementComputer.ts

fbw-a380x/src/systems/instruments/src/MFD/FMC/FmcInterface.ts

BlueberryKing · 2025-01-29T12:57:44Z

fbw-a380x/src/systems/instruments/src/MFD/pages/FMS/F-PLN/MfdFmsFplnVertRev.tsx

-      if (revWptIdx && this.props.fmcService.master?.revisedWaypointIndex.get() !== undefined) {
-        this.selectedWaypointIndex.set(revWptIdx - activeLegIndex - 1);
+      const revWptIdx = this.props.fmcService.master?.revisedWaypointLegIndex.get();
+      if (revWptIdx !== null && revWptIdx !== undefined) {


When would revWptIdx be null or undefined? In this case, we should probably also set selectedLegIndex to null or undefined. Otherwise we may get into a bit of an awkward state where revWptIdx is falsy but selectedLegIndex is not.

Indeed, selectedLegIndex should also be changed.
revisedLegIndex can be undefined if there's no FMC present or not yet initialized (i.e. this.props.fmcService.master resolves to undefined), and null if no leg is currently being revised

fbw-a380x/src/systems/instruments/src/MFD/pages/FMS/F-PLN/MfdFmsFplnVertRev.tsx

BlueberryKing · 2025-01-29T13:43:56Z

fbw-a380x/src/systems/instruments/src/MFD/pages/FMS/F-PLN/MfdFmsFplnVertRev.tsx

+      this.props.fmcService.master.flightPlanService.setPilotEnteredSpeedConstraintAt(
+        this.selectedLegIndex,
+        this.spdConstraintTypeRadioSelected.get() === 1,
+        newSpeed ?? 250,


What is the reason for this default value?

No reason, I somehow thought that setPilotEnteredSpeedConstraintAt always expects a speed constraint but this makes it impossible to delete them. Removed the default value.

fbw-a380x/src/systems/instruments/src/MFD/pages/FMS/F-PLN/MfdFmsFplnVertRev.tsx

BlueberryKing · 2025-01-29T13:52:30Z

fbw-a380x/src/systems/instruments/src/MFD/pages/FMS/F-PLN/MfdFmsFplnVertRev.tsx

+    }
+  }
+
+  private tryDeleteCruiseStep(lineIndex: number, dropdownIndex: number, altitude: number | null) {


Why do we need altitude here?

If either the waypoint field or the altitude field is un-set, the cruise step shall be deleted (that's how I think it works). But it's better to do this check in the input field which calls the method, not here. So I moved it.

BlueberryKing · 2025-01-29T14:00:57Z

fbw-a380x/src/systems/instruments/src/MsfsAvionicsCommon/UiWidgets/RadioButtonGroup.tsx

-          document.getElementById(`${this.props.idPrefix}_label_${idx}`)?.classList.remove('white');
-
-          document.getElementById(`${this.props.idPrefix}_label_${idx}`)?.classList.add(v);
+          document


Can we store a ref to the element rather than fetching it with getElementById?

Great idea! Changed the whole class to refs instead of getElementById

BlueberryKing · 2025-01-29T14:04:59Z

fbw-a380x/src/systems/instruments/src/MFD/pages/FMS/F-PLN/MfdFmsFplnVertRev.tsx


-  private tmpyInsertButtonDiv = FSComponent.createRef<HTMLDivElement>();
+  set selectedLegIndex(legIndex: number | null) {


This is something I don't understand about the avionics framework. You have a lot of derived state in this component. For example selectedLegIndex can be derived immediately from dropdownMenuSelectedWaypointIndex and availableWaypointsToLegIndex. This means you have quite a bit of code to keep these state variables in-sync. Would it make more sense to derive e.g selectedLegIndex at render time or is this the proper way to do it with the framework?

Usually you would used MappedSubjects for that. You don't invalidate an entire component and rebuild the whole DOM for it like react because that's incredibly expensive, and why react instruments cause stutter.

We talked on Discord about that. Ideally you would also use MappedSubjects for e.g. selectedLegIndex, but in this case the dependencies are kind of convoluted and not fully subject-ified (for example the flight plan data), so I think it's better to stick with the function approach for now. But I'm having another look over it right now, maybe that might change.

utkrishtm · 2025-01-31T16:39:08Z

Quick question @flogross89. Is there a way to fully automate the auto-step climb like the PMDG? The FMS already calculates the OPT FL and can predict when it should climb. Just a thought.

flogross89 · 2025-01-31T17:13:05Z

Quick question @flogross89. Is there a way to fully automate the auto-step climb like the PMDG? The FMS already calculates the OPT FL and can predict when it should climb. Just a thought.

In principle that's possible, we would need optimum step climb calculation for that though, which is out of scope of this PR. But can be added in the future.

fbw-a380x/src/systems/instruments/src/MFD/pages/FMS/F-PLN/MfdFmsFplnVertRev.tsx

utkrishtm · 2025-01-31T18:54:42Z

Quality Assurance Trainee Report

Discord Username : utkrishtm
Object of testing : #9804
Aircraft : A380X
Tier of Testing : 1
Date : 31/01/2025

Testing Process:

Flight from KSEA to PHNL 2363NM.
Initial climb to FL 340. OPT FL 380 shown in the FMS. Climbed initially to FL 340 by point HQM
Added Step climbs
SEDAR FL 360 (137 NM from HQM)
43N131W FL 380 (238 NM from SEDAR)
40N136W FL 400 (288 NM from 43N131W)
37N140W FL 380 (260 NM from 40N136W)
HELOP FL 360 (165 NM from 37N140W)

Route: HAROB6 HQM DCT SEDAR DCT 43N131W 40N136W 37N140W DCT HELOP A332 AUNTI R463 APACK MAGGI3

Testing Results:
Not Passed

Negatives:

After the second step climb occurred, the S/D point disappeared from the FLPN page. Including removing the step climb from the STEPALTs page as well. I could not again program the step descent. 37N140W was programmed to be a S/D to FL 380. However, it was automatically edited to be FL 400. Once I changed the FL to 360 manually the other S/D at HELOP came back with the wrong altitude. When I tried to change HELOP to FL 360, it automatically added a S/C with the wrong altitude (Video Attached).

After the third step climb, it successfully reached FL 400; however, it removed the next point at 37N140W, which was a S/D to FL 380.

I tried to edit the point; however, when I tried to change HELOP to 37N140W, it wouldn't let me (see the Video Attached). I had to delete the entire point and then add 37N140W again. I'm not sure if that behavior is intended.
https://github.com/user-attachments/assets/fee4d3e6-9323-436a-8024-be2da32d7d5a

I wanted to re-program to add HELOP as a S/D but couldnt do. It kept changing automatically to HALLI (Video Attached).
After 37N140W which descended to FL 360, the HELOP point came back even though it was not on the list.

Conclusions:

The first step climb worked as intended. 20NM before the S/C point, the message was displayed. It climbed to FL 360 and did not remove any other step climbs that were programmed in the FMS. The FLPN page automatically added the next S/C point.
The second step climb worked as intended. 20NM before the S/C point, the message was displayed. It climbed to FL 380 but it removed the other step descent that was programmed in the FMS. The FLPN page automatically added the next S/C point.
The third step climb worked as intended. 20NM before the S/C point, the message was displayed. It climbed to FL 400.
The fourth step which was a S/D worked as intended after which there were no more Step Climbs or Descents.

Media:

Original Programming of Step Climbs

Step Climb 1:

Step Climb 2:

Step Climb 3:

Please do let me know if anything is confusing here. Sorry if I dumped everything here.

utkrishtm · 2025-02-01T16:45:20Z

Quality Assurance Trainee Report

Discord Username : utkrishtm
Object of testing : #9804
Aircraft : A380X
Tier of Testing : 1
Date : 01/02/2025

Testing Process:

Testing UI only
Flight from KSEA to PHNL 2363NM.
Initial climb to FL 340. OPT FL 380 shown in the FMS. Climbed initially to FL 340 by point HQM
Added Step climbs
SEDAR FL 360 (137 NM from HQM)
43N131W FL 380 (238 NM from SEDAR)
40N136W FL 400 (288 NM from 43N131W)
37N140W FL 380 (260 NM from 40N136W)
HELOP FL 360 (165 NM from 37N140W)

Route: HAROB6 HQM DCT SEDAR DCT 43N131W 40N136W 37N140W DCT HELOP A332 AUNTI R463 APACK MAGGI3

Testing Results:
Not Passed

Negatives:

I added all the above-mentioned points to the STEP ALTs page. After that, I cleared the entire list. However, it wasn't cleared out completely. After which, if I try to add the same point, it won't come up, but if I click on it again, it is displayed. Please see the video attached.

Media:
https://www.swisstransfer.com/d/c9173a82-0f27-44e9-a04b-d48c54a327a1

ApostaL777rus · 2025-02-01T21:31:20Z

Hi to all!
How i can install this?

flogross89 · 2025-02-03T18:18:46Z

Hi to all! How i can install this?

It's currently being tested, however you will be able to install it via the installer (when choosing development version) after this has merged.

flogross89 · 2025-02-03T18:21:51Z

Quality Assurance Report

Discord Username : floridude
Object of testing : #9804
Aircraft : A380X
Tier of Testing : 2
Date : 03/02/2025

Testing Process:

Set up flight from EDDM to EDDH with CRZ FL 240. Start at gate, set up FMS including two step climbs to FL260 (at ANELA) and FL280 (at LASGA). Auto Step Climb was enabled in the EFB.
Take-off, climb to FL240, don't touch aircraft. Both step climbs were performed automatically successfully.
Turn around, program a few waypoints, program step descend to FL260 --> also performed successfully + automatically

Testing Results:
Passed

Media:

cheddar22 · 2025-02-04T07:22:39Z

Fixes #9486

Summary of Changes

Adds step climbs to A380X.

Changes:

STEP ALTs tab of VERT REV page implemented

Interface to flight plan correctly integrated

Allow selection of CLB/DES constraint for SPD and ALT constraints

Add "auto step climb" QoL function

Add "ABOVE MAX FL" / "STEP DELETED" messages

Out of scope (i.e. not implemented):

Optimum step point (requires deeper FMS changes)

Subscriptions cleanup for pages other than VERT REV to be done in chore(a380x/mfd): Subscriptions overhaul #9807

Changelog will be added shortly before merge.

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

Load up cold&dark at airport, plan long enough flight (>3h) in Simbrief; Enable "Auto Step Climb" in EFB Realism Settings

Fill in FMS as per normal procedures

Insert step climbs or step descends (not too close to T/C or T/D, otherwise they'll get ignored)

Delete step climbs or descends (clear altitude and/or waypoint field), see whether that works

Enter step climb above max FL, should be ignored with "ABOVE MAX FL" message

Start flight, take-off, fast forward to cruise (sim rate can be increased)

When approaching S/C waypoint (at 20nm distance), the aircraft should display "STEP AHEAD" in the FMS message field. If Auto Step climb is enabled, the FCU alt should be automatically set to the new value, and CLB/DES should be engaged

Verify that step climbs or descends work as intended, with or without Auto Step Climbs enabled

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

Make sure you are signed in to GitHub

Click on the Checks tab on the PR

On the left side, find and click on the PR Build tab

Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

hi there, i am in no means a IT guy but wanted to try this one out but it bugs out with navigraph charts, therefore i cant connect due to "insufficient .env file

aadee9940 · 2025-02-04T07:25:36Z

@cheddar22 this has already been merged, use the installer as per normal.

ApostaL777rus · 2025-02-04T10:20:58Z

Hi to all! How i can install this?

It's currently being tested, however you will be able to install it via the installer (when choosing development version) after this has merged.

now i use develop version, bit step climb not avail...

flogross89 · 2025-02-04T14:54:50Z

Hi to all! How i can install this?

It's currently being tested, however you will be able to install it via the installer (when choosing development version) after this has merged.

now i use develop version, bit step climb not avail...

Did you update the version via the installer? Could take a few hours to refresh

utkrishtm · 2025-02-04T19:30:09Z

Enable "Auto Step Climb" in EFB Realism Settings

Also, did you Enable "Auto Step Climb" in EFB Realism Settings?

flogross89 added 3 commits January 25, 2025 23:34

first draft

4730486

rename

d0bfd16

more stuff

a06c9b5

flogross89 added FMS QA A380 Only QA only for A380 required A380X Related to the A380X aircraft labels Jan 26, 2025

flogross89 added this to the v0.13.0 milestone Jan 26, 2025

flogross89 added 2 commits January 26, 2025 21:05

subscriptions overhaul

fca9899

readme.md

15c6054

flogross89 added 2 commits January 27, 2025 02:08

add STEP AHEAD FMS message; add auto step climb function

7ad74d8

Merge branch 'master' into feat-a380x-fms-step-climb

61cb238

flogross89 changed the title ~~feat(a380x/fms): Add step climbs; Allow CLB/DES constraint selection~~ feat(a380x/fms): Add (auto) step climbs; Allow CLB/DES constraint selection Jan 27, 2025

flogross89 added 3 commits January 27, 2025 19:05

change radio button color to enum

ab4f22d

add CLB/DES selection; un-bork some stuff

e55c70c

remove console.log

441bc6e

flogross89 marked this pull request as ready for review January 27, 2025 17:22

add "ABOVE MAX FL", "STEP DELETED"

8f1f90a

flogross89 added 3 commits January 28, 2025 00:07

Merge branch 'master' into feat-a380x-fms-step-climb

74a12bc

fix STEP ALTs message

8d2ed52

Merge branch 'master' into feat-a380x-fms-step-climb

329230a

flogross89 requested a review from BlueberryKing January 28, 2025 17:01

CRZ FL not mandatory after descent (shows dashes)

7dc238c

BlueberryKing requested changes Jan 29, 2025

View reviewed changes

flogross89 added 2 commits January 29, 2025 18:14

rename stuff

09a2de1

review comments

47ebb8f

BlueberryKing approved these changes Jan 30, 2025

View reviewed changes

flogross89 force-pushed the feat-a380x-fms-step-climb branch from 42b3fe0 to 6cbb0b4 Compare January 31, 2025 01:31

BravoMike99 reviewed Jan 31, 2025

View reviewed changes

fbw-a380x/src/systems/instruments/src/MFD/pages/FMS/F-PLN/MfdFmsFplnVertRev.tsx Outdated Show resolved Hide resolved

fbw-a380x/src/systems/instruments/src/MFD/pages/FMS/F-PLN/MfdFmsFplnVertRev.tsx Outdated Show resolved Hide resolved

flogross89 added 3 commits February 1, 2025 01:44

update TIME/UTC info

3bdaefd

Merge branch 'master' into feat-a380x-fms-step-climb

3f5ecfb

enable step modification, improve step deletion code

2a729b1

flogross89 added 6 commits February 2, 2025 17:58

Merge branch 'master' into feat-a380x-fms-step-climb

69db6c6

radio button fixes

0089cc9

little cleanup

4427f91

dropdown fixes

76e0d7c

scrolling fixes

653a76f

changelog

a7dd893

flogross89 mentioned this pull request Feb 2, 2025

chore(a380x/mfd): Subscriptions overhaul #9807

Merged

rebuild cruise step list if cruise step was added/deleted by the FMS

edfcbff

github-actions bot added QA Passed and removed QA Failed QA Ready to Test labels Feb 3, 2025

flogross89 merged commit 0e1ed4f into flybywiresim:master Feb 3, 2025
8 checks passed

flogross89 deleted the feat-a380x-fms-step-climb branch February 4, 2025 14:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(a380x/fms): Add (auto) step climbs; Allow CLB/DES constraint selection #9804

feat(a380x/fms): Add (auto) step climbs; Allow CLB/DES constraint selection #9804

flogross89 commented Jan 26, 2025 •

edited

Loading

aadee9940 commented Jan 26, 2025

flogross89 commented Jan 26, 2025

BravoMike99 commented Jan 27, 2025

flogross89 commented Jan 27, 2025

BlueberryKing left a comment

BlueberryKing Jan 29, 2025

flogross89 Jan 29, 2025

BlueberryKing Jan 29, 2025

flogross89 Jan 29, 2025

BlueberryKing Jan 29, 2025

flogross89 Jan 29, 2025

BlueberryKing Jan 29, 2025

flogross89 Jan 29, 2025

BlueberryKing Jan 29, 2025

tracernz Jan 30, 2025 •

edited

Loading

flogross89 Jan 31, 2025

utkrishtm commented Jan 31, 2025

flogross89 commented Jan 31, 2025

utkrishtm commented Jan 31, 2025

utkrishtm commented Feb 1, 2025

ApostaL777rus commented Feb 1, 2025

flogross89 commented Feb 3, 2025

flogross89 commented Feb 3, 2025

cheddar22 commented Feb 4, 2025

Summary of Changes

Screenshots (if necessary)

References

Additional context

Testing instructions

How to download the PR for QA

aadee9940 commented Feb 4, 2025

ApostaL777rus commented Feb 4, 2025

flogross89 commented Feb 4, 2025

utkrishtm commented Feb 4, 2025 •

edited

Loading


		private tmpyInsertButtonDiv = FSComponent.createRef<HTMLDivElement>();
		set selectedLegIndex(legIndex: number \| null) {

feat(a380x/fms): Add (auto) step climbs; Allow CLB/DES constraint selection #9804

feat(a380x/fms): Add (auto) step climbs; Allow CLB/DES constraint selection #9804

Conversation

flogross89 commented Jan 26, 2025 • edited Loading

Summary of Changes

Screenshots (if necessary)

References

Additional context

Testing instructions

How to download the PR for QA

aadee9940 commented Jan 26, 2025

flogross89 commented Jan 26, 2025

BravoMike99 commented Jan 27, 2025

flogross89 commented Jan 27, 2025

BlueberryKing left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tracernz Jan 30, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

utkrishtm commented Jan 31, 2025

flogross89 commented Jan 31, 2025

utkrishtm commented Jan 31, 2025

utkrishtm commented Feb 1, 2025

ApostaL777rus commented Feb 1, 2025

flogross89 commented Feb 3, 2025

flogross89 commented Feb 3, 2025

cheddar22 commented Feb 4, 2025

Summary of Changes

Screenshots (if necessary)

References

Additional context

Testing instructions

How to download the PR for QA

aadee9940 commented Feb 4, 2025

ApostaL777rus commented Feb 4, 2025

flogross89 commented Feb 4, 2025

utkrishtm commented Feb 4, 2025 • edited Loading

flogross89 commented Jan 26, 2025 •

edited

Loading

tracernz Jan 30, 2025 •

edited

Loading

utkrishtm commented Feb 4, 2025 •

edited

Loading