Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fms): use station declination when required for terminal procedures #9801

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

BlueberryKing
Copy link
Member

Fixes #[issue_no]

Summary of Changes

Another day, another magvar issue.

  • Makes sure to use the station declination to compute the true radial bearing for CR/VR legs referencing a VOR navaid.
  • Also fixes an issue where two discontinuities would exist in the flight plan after removing a departure transition. This happened because the flight plan was not restrung when the transition was removed, so both the discontinuity between sid and en route transition as well as the discontinuity between en route transition and en route segment persisted.

Screenshots (if necessary)

image

References

Additional context

Discord username (if different from GitHub):

Testing instructions

  • Try one of
    • KEWR/04L EWR 5,
    • EGGP/09 POL 5V,
    • FACT/19 OKTED 1C,
    • LDDU/29 BEVIS 3D
    • LGAV/03L ROPOX 1D
    • LIMC/35L IPCUC 7F
    • or any other procedure you know of containing a CR/VR leg
  • Make sure that all fixes are where you would expect them according to the chart.
  • Enter a flight plan with a departure transition (common in the US). Remove the departure transition, make sure you only see one discontinuity in the flight plan.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@BlueberryKing BlueberryKing changed the title fix(fms): use station declination for cr/vr legs referencing a vor fix(fms): use station declination when required for terminal procedures Jan 25, 2025
@@ -166,6 +166,7 @@ export class MsfsMapping {
longestRunwaySurfaceType: this.mapRunwaySurface(longestRunway[1]?.surface),
transitionAltitude,
transitionLevel,
magneticVariation: msAirport.magvar,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only available in MSFS2024. Should we fill this with the WMM value in 2020?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🟡 Code Review: Ready for Review
Development

Successfully merging this pull request may close these issues.

1 participant