Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fms): more robust navdata error handling and sorting #9774

Merged
merged 3 commits into from
Jan 18, 2025

Conversation

tracernz
Copy link
Member

Fixes #[issue_no]

Summary of Changes

Improve robustness of procedure loading, discard procedures that are missing data rather than discarding entire airports.
Sort the procedures in the A32NX FMS (this is necessary when navdata is coming from multiple sources).

This potentially helps with INTERNAL ERROR, and certainly helps with some navdata issues I've seen.

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

Loading some airports in the A32NX, and ensure the procedures work okay (step through in PLAN mode), and that procedures are sorted in order on the arrival and departure pages.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@tracernz tracernz added this to the v0.13.0 milestone Jan 17, 2025
@BravoMike99
Copy link
Contributor

Quality Assurance Tester Report

Discord Username : bruno_pt99
Object of testing : #9774
Aircraft : A32NX
Tier of Testing : 1
Date : 18/01/2025

Testing Process:
Loaded multiple procedures such as LPPT 02 IXIDA1N, LPPR 17 ABLEG3M, LPPD ETROX2B RNP AR RWY 30 & LPMA 05 GALOZ1E and verified they are coded correctly ✔️
Verified SIDs & STARs appear sorted alphabetically in the available departure/arrival pages ✔️

Testing Results:
Passed

Media:
image
image
image
image
image
image
image
image

@tracernz tracernz enabled auto-merge (squash) January 18, 2025 11:35
@tracernz tracernz merged commit ce500c1 into flybywiresim:master Jan 18, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

3 participants