Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a380x/fms): Fix mach crossover altitude & T/O perf characteristic speeds #9769

Merged
merged 11 commits into from
Jan 18, 2025

Conversation

flogross89
Copy link
Contributor

@flogross89 flogross89 commented Jan 16, 2025

Fixes #9764
Fixes #9741

Summary of Changes

  • Also update characteristic speeds when ADR CAS data NCD (i.e. low speed/standstill)
  • Remove CI-dependent cruise speed calculation, not mature enough
  • Fix speed/mach switchover
  • Fix FMS/PERF page formatting: --- when no value for speeds

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

  1. Set up FMS with CRZ ALT > FL310, confirm Speed does not always transition from climb speed to cruise Mach #9764 doesn't occur anymore (i.e. managed speed is switching to correct mach speed above FL300)
  2. Confirm that characteristic speeds on T.O PERF page show correct speeds, depending on weight

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@flogross89 flogross89 added QA A380 Only QA only for A380 required A380X Related to the A380X aircraft labels Jan 17, 2025
@flogross89 flogross89 added this to the v0.13.0 milestone Jan 17, 2025
@flogross89 flogross89 marked this pull request as ready for review January 17, 2025 04:48
@flogross89 flogross89 requested a review from tracernz January 17, 2025 05:18
Copy link
Member

@tracernz tracernz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

# Conflicts:
#	fbw-a380x/src/systems/shared/src/OperatingSpeeds.tsx
@Jaronics
Copy link

Quality Assurance Trainee Report

Discord Username : Jaronics
Object of testing : #9769
Aircraft : A380X
Tier of Testing : 1
Date : 18/01/2025

Testing Process:

  1. Loaded a flight with a cruising altitude at FL380
  2. T.O page shows speeds corresponding to the weight
  3. Aircraft transitions to MACH

Testing Results:
Passed

Negatives:
None

Conclusions:
None

Media:

Screenshot 2025-01-18 094846
Screenshot 2025-01-18 104800

# Conflicts:
#	.github/CHANGELOG.md
@flogross89 flogross89 force-pushed the fix-a380x-managed-mach branch from 4850214 to c07486d Compare January 18, 2025 17:10
@flogross89 flogross89 enabled auto-merge (squash) January 18, 2025 17:10
@flogross89 flogross89 merged commit 886180b into flybywiresim:master Jan 18, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A380X Related to the A380X aircraft QA A380 Only QA only for A380 required QA Passed QA Ready to Test
Projects
None yet
3 participants