-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(a32nx/fws): Fix AP disconnection via 3D model inst. disc. push button #9695
base: master
Are you sure you want to change the base?
fix(a32nx/fws): Fix AP disconnection via 3D model inst. disc. push button #9695
Conversation
Quality Assurance Report Discord Username : Kiwi0. Testing Process:
Testing Results: |
} els{ | ||
1 (>L:A32NX_PRIORITY_TAKEOVER:#ID#) | ||
} | ||
1 (>L:A32NX_PRIORITY_TAKEOVER:#ID#) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We actually had a discussion about this on Discord recently and the conclusion was that we should use events instead, as short clicks often do not register this way.
Suggest doing both, and reverting the AP change.
1 (>L:A32NX_PRIORITY_TAKEOVER:#ID#) | |
(>K:AUTOPILOT_OFF) | |
1 (>L:A32NX_PRIORITY_TAKEOVER:#ID#) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kept both the event and Lvar now, but FMGC/AP doesn't react to the PRIORITY_TAKEOVER Lvar anymore (only to the known AP OFF K events)
ed8aaa4
to
998be42
Compare
Summary of Changes
Fixes issue with the 3D model instinctive disconnect button on the sidesticks (reported in a32nx-support)
Reference: https://discord.com/channels/738864299392630914/785976111875751956/1321142810010849302
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub):
Testing instructions
A32NX only:
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.