Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a32nx/fws): Fix AP disconnection via 3D model inst. disc. push button #9695

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

flogross89
Copy link
Contributor

@flogross89 flogross89 commented Dec 31, 2024

Summary of Changes

Fixes issue with the 3D model instinctive disconnect button on the sidesticks (reported in a32nx-support)
Reference: https://discord.com/channels/738864299392630914/785976111875751956/1321142810010849302

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

A32NX only:

  1. Start flight, no FMS setup needed
  2. Engage autopilot
  3. Disengage autopilot via the 3D model inst. disc. button on the sidestick. Press once to disengage, twice to silence the cavalry charge. Cav charge should be silenced with second press
  4. Also verify disengaging autopilot still works with (joystick) keybinds

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@flogross89 flogross89 added A32NX Related to the A32NX aircraft FWS Flight Warning Computer (ata-31) labels Dec 31, 2024
@kiwi2021
Copy link
Member

kiwi2021 commented Dec 31, 2024

Quality Assurance Report

Discord Username : Kiwi0.
Object of testing : #9695
Aircraft : A32NX
Tier of Testing : 1
Date : 31/12/2024

Testing Process:

  1. Loaded aircraft onto runway
  2. After takeoff, set autopilot
  3. Disconnected A/P via model autopilot disconnect button
  4. Pressed again shortly after to silence Cavalry and clear ECAM
  5. Re-engaged A/P and disconnected via TCA Thrustmaster Joystick with keybind 'Set Autopilot Disengage'
  6. Successful again both disconnect and Cavalry silence

Testing Results:
Passed

} els{
1 (>L:A32NX_PRIORITY_TAKEOVER:#ID#)
}
1 (>L:A32NX_PRIORITY_TAKEOVER:#ID#)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually had a discussion about this on Discord recently and the conclusion was that we should use events instead, as short clicks often do not register this way.
Suggest doing both, and reverting the AP change.

Suggested change
1 (>L:A32NX_PRIORITY_TAKEOVER:#ID#)
(>K:AUTOPILOT_OFF)
1 (>L:A32NX_PRIORITY_TAKEOVER:#ID#)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kept both the event and Lvar now, but FMGC/AP doesn't react to the PRIORITY_TAKEOVER Lvar anymore (only to the known AP OFF K events)

@flogross89 flogross89 force-pushed the fix-a32nx-inst-disc-pb-model branch from ed8aaa4 to 998be42 Compare January 3, 2025 01:55
@flogross89 flogross89 requested a review from tracernz January 3, 2025 02:00
@flogross89 flogross89 added this to the v0.13.0 milestone Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A32NX Related to the A32NX aircraft FWS Flight Warning Computer (ata-31) QA Passed
Projects
Status: 🟡 Code Review: Ready for Review
Development

Successfully merging this pull request may close these issues.

3 participants