Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a380x/fctl): Protection speeds improvements after flight model update #9694

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

flogross89
Copy link
Contributor

@flogross89 flogross89 commented Dec 31, 2024

Fixes #9689
Fixes #8725

Summary of Changes

  • Adapted zero lift alpha to MSFS flight model values:
    image
  • Adapt alpha max and alpha prot values to match existing references
  • Fix high speed protection green double bar in PFD
  • Fix protection markers in PFD (and add simplified FCDC in the process)
  • Fix VMAX / VfeNext for CONF 1+F and CONF 1

Screenshots (if necessary)

image

vs
image

image
vs
image

image
vs
image

PFD direct law indications:
image

References

https://www.youtube.com/watch?v=hDh_9MEz-hg
https://www.youtube.com/watch?v=AI8yFhuEa4Q
https://www.youtube.com/watch?v=pHui34_ODnc
https://www.youtube.com/watch?v=qcXQKQukxkI&t=284s
https://www.youtube.com/watch?v=DtIF26FEZug&t=338s

Additional context

Note for reviewer: Only alpha max and alpha protection look-up tables were modified in the MATLAB models, no MATLAB review needed.

Current alpha tables:
alpha_max:
image

alpha_prot:
image

Discord username (if different from GitHub):

Testing instructions

  1. Verify protection markers (pitch&roll, overspeed) show correctly in PFD in normal and in direct law (disable all PRIMs for that)
  2. Fly around, try to match PFD protection speeds to known references and report where they deviate
  3. Even without looking at references, the aircraft should perform reasonably, e.g. shouldn't activate protections at green dot speed in clean conf in standard turns.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@flogross89 flogross89 force-pushed the fix-a380x-fac-alpha-after-don branch from 2c3ace7 to 287cd2e Compare January 2, 2025 04:07
@flogross89 flogross89 force-pushed the fix-a380x-fac-alpha-after-don branch from 9062486 to 9583e06 Compare January 2, 2025 22:38
@flogross89 flogross89 changed the title fix(a380x/prim): Adapt alpha speeds after flight model update fix(a380x/fctl): Protection speeds improvements after flight model update Jan 2, 2025
@flogross89 flogross89 marked this pull request as ready for review January 2, 2025 22:41
@flogross89 flogross89 added QA A380 Only QA only for A380 required A380X Related to the A380X aircraft labels Jan 2, 2025
@flogross89 flogross89 added this to the v0.13.0 milestone Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A380X Related to the A380X aircraft QA A380 Only QA only for A380 required
Projects
Status: 🟡 Code Review: Ready for Review
Development

Successfully merging this pull request may close these issues.

A380X PFD Overspeed Protection Symbols Missing [A380X] PRIM FE: Fix protection speeds
1 participant