Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(a380x/fcu): add TRUE indication on FCU when TRUE/MAG pb is pushed #9678

Merged
merged 4 commits into from
Jan 13, 2025
Merged

feat(a380x/fcu): add TRUE indication on FCU when TRUE/MAG pb is pushed #9678

merged 4 commits into from
Jan 13, 2025

Conversation

heclak
Copy link
Contributor

@heclak heclak commented Dec 26, 2024

Fixes #9519

Summary of Changes

  • add logic for TRUE indicator to display when true north ref is selected on AFS CP
  • partial port of heading display to MSFS Avionics Framework

Screenshots (if necessary)

image

References

image

Additional context

Discord username (if different from GitHub): Heclak

Testing instructions

  1. Select TRUE and check that TRUE light lights up in the AFS CP
  2. Select MAG after check is complete and check that TRUE light is extinguished in the AFS CP.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@heclak
feat(a380x/fcu): add TRUE indication on FCU when TRUE/MAG pb is pushed
067800e 
* add logic for TRUE indicator to display when true north ref is selected on AFS CP
* partial port of heading display to MSFS Avionics Framework

Fixes flybywiresim#9519
BravoMike99
BravoMike99 requested changes Dec 29, 2024
View reviewed changes
Copy link
Contributor

@BravoMike99 BravoMike99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor thing

fbw-a380x/src/systems/instruments/src/FCU/Components/Heading.tsx Outdated Show resolved Hide resolved
@BravoMike99
Copy link
Contributor

Please resolve conflicts when able

@heclak
Copy link
Contributor Author

heclak commented Jan 9, 2025

Please resolve conflicts when able

Conflicts in changelog resolved. @BravoMike99

@BravoMike99 BravoMike99 added QA Tier 1 QA Ready to Test A380X Related to the A380X aircraft labels Jan 9, 2025
@BravoMike99
Copy link
Contributor

Quality Assurance Tester Report
Discord Username : bruno_pt99
Object of testing : #9678
Aircraft : A380X
Tier of Testing : 1
Date : 13/01/2025

Testing Process:
Selected true heading via the FCU, verified TRUE label appears on the heading display ✔️
When switching back to magentic heading the TRUE label disappears ✔️

Testing Results:
Passed

Media:
image
image

@BravoMike99 BravoMike99 merged commit 007db04 into flybywiresim:master Jan 13, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BravoMike99 BravoMike99 BravoMike99 approved these changes

@tracernz tracernz tracernz approved these changes

Assignees
No one assigned
Labels
A380X Related to the A380X aircraft QA Passed QA Ready to Test QA Tier 1
Projects
Quality Assurance
Status: ✔️ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The TRUE light in the AFS CP does not light up when TRUE/MAG push button is set to TRUE
3 participants
@heclak @BravoMike99 @tracernz