Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move failure orchestrator to commbus/eventsync #9657

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

tracernz
Copy link
Member

@tracernz tracernz commented Dec 14, 2024

Fixes #[issue_no]

Summary of Changes

Moves the failure orchestrator to CommBus (for WASM) and event sync (for JS). The design is intentionally very simple, the orchestrator sends the complete active failure list for each of the following reasons:

  • the actives failures changed,
  • an instrument requested it (should be done on init),
  • the orchestrator initialised.

The benefits are:

  • All instruments always have an identical view of active failures regardless of instrument reloading/load order/etc.
  • A given failure can be used/inspected reliably on more than one instrument.

In future when we don't need to use this in react instruments anymore we can further improve the typescript side with EventBus and SetSubject.

TODO:

  • Rework TS tests - tracernz
  • Implement Rust version - Gurgel
    - [ ] Check if/what docs need updated - tracernz The code was the documentation.

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@tracernz tracernz added A32NX Related to the A32NX aircraft A380X Related to the A380X aircraft labels Dec 14, 2024
@Gurgel100 Gurgel100 marked this pull request as ready for review December 14, 2024 18:46
@Gurgel100 Gurgel100 marked this pull request as draft December 14, 2024 18:47
@tracernz tracernz marked this pull request as ready for review January 17, 2025 13:16
@tracernz tracernz force-pushed the mrc-failure-orch-commbus branch from 0f7a443 to 4ad7fb6 Compare January 17, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A32NX Related to the A32NX aircraft A380X Related to the A380X aircraft
Projects
Status: 🟡 Code Review: Ready for Review
Development

Successfully merging this pull request may close these issues.

2 participants