Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a380x): missing tooltip declarations #9644

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

LelouchTwT
Copy link

Fixes #9214

Summary of Changes

I corrected the missing tooltip declarations in the LOK file, updated the autobrake tooltips key to match the LOK file, and created a new tooltip for the button that switches from true heading to magnetic. Previously, it was incorrectly using the "AP ENGAGE" tooltip.

Screenshots (if necessary)

References

Additional context

The autobrake tooltips, except for RTO, were referencing a mismatched key in the LOK file.
Tooltips for the AUTO signs were undefined.
I overwrote the ENG 1 and ENG 2 de-ice tooltips because they were labeled as left and right engine de-ice.

Discord username (if different from GitHub):
lelouchtwt

Testing instructions

The updates I made are purely visual. You only need to hover over the buttons to see the tooltips. There are different tooltips for each state.

How to download the PR for QA

Every new commit to this PR will cause new A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@LelouchTwT LelouchTwT changed the title Fix/a380x missing tooltip declarations fix/a380x missing tooltip declarations Dec 10, 2024
@LelouchTwT LelouchTwT changed the title fix/a380x missing tooltip declarations fix(a380x): missing tooltip declarations Dec 10, 2024
@Benjozork Benjozork requested a review from frankkopp December 10, 2024 16:46
@tracernz
Copy link
Member

Hi, that COCKPIT.TOOLTIPS prefix is from the fs-base package that is part of the base sim and we should not define any keys with that prefix. All of the new tooltips should follow the RMP example and use a name like A380X.TOOLTIPS.<system>_<item>_<tooltip type>. The tool top type is TITLE or ACTION where TITLE is “PANEL LIGHTING BRIGHTNESS” in this pic and ACTION is “Adjust panel lighting brightness”.

image

@Benjozork Benjozork added the A380X Related to the A380X aircraft label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A380X Related to the A380X aircraft
Projects
Status: 🟡 Code Review: Ready for Review
Development

Successfully merging this pull request may close these issues.

Some switches/buttons have incorrect/missing tooltips in the overhead panel.
3 participants