Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(a380x/mfd): add ATCCOM D-ATIS page #9535

Merged

Conversation

heclak
Copy link
Contributor

@heclak heclak commented Nov 16, 2024

Fixes #[issue_no]

Summary of Changes

To implement D-ATIS page in the ATC COM. This will focus on the layout and some basic UI functionality to prepare for ATSU implementation.

  • Implemented the layout for D-ATIS/LIST and D-ATIS/RECEIVED pages.
  • Updated IconButton icons to use viewBox property in order to be scalable with the button size. A default size of 35px was retained to maintain compatibility with existing uses of the IconButton.

Screenshots (if necessary)

image
image
image

References

image

image

image

https://www.youtube.com/watch?v=AI8yFhuEa4Q&t=5375s

Additional context

Discord username (if different from GitHub): Heclak

Testing instructions

  1. Navigate to D-ATIS page via ATCCOM menu. Verify that page is showing correctly. Match visuals to screenshots above.
  2. Verify the icon buttons on F-PLN page is still rendering correctly.

image

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@heclak
Copy link
Contributor Author

heclak commented Nov 18, 2024

Initial layout pass of D-ATIS page done, some elements still missing. Work is still to be completed with the other states of the ATIS blocks and message logic. Will add some logic to the ATIS blocks.

image

@corsica002b
Copy link

Hello, is it possible to download your work to test it? Thank you

@heclak
Copy link
Contributor Author

heclak commented Nov 18, 2024

Hello, is it possible to download your work to test it? Thank you

The ATSU and router code isn't functional yet so there is no real function to test at the moment. This is only an early layout/ui logic implementation.

* Add D-ATIS Received page
* Tweak IconButton to make icon size scalable by adding the viewBox prop. Icon size still defaults to 35px to maintain compatibility with existing buttons.
* clean up layout code
@heclak
Copy link
Contributor Author

heclak commented Dec 7, 2024

Initial layout completed. INOP overlay similar to CONNECT page was implemented until full function is implemented. Will be following up with a logic PR after additional systems are completed. There is a tweak needed for the tab sizes/overlapping that will be done in a separate PR instead to facilitate QA testing.

image
image
image

@heclak heclak marked this pull request as ready for review December 7, 2024 00:25
Copy link
Contributor

@flogross89 flogross89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heclak
Copy link
Contributor Author

heclak commented Dec 11, 2024

Thanks!

@flogross89 flogross89 added the A380X Related to the A380X aircraft label Dec 11, 2024
@flogross89 flogross89 added this to the v0.13.0 milestone Dec 11, 2024
@flogross89 flogross89 added QA A380 Only QA only for A380 required QA Ready to Test labels Dec 11, 2024
@mattking247
Copy link

mattking247 commented Dec 27, 2024

Quality Assurance Tester Trainee Report

Discord Username : Matt
Object of testing : #9535
Aircraft : A380X
Tier of Testing : 1
Date : 27/12/2024

Testing Process: On the ground at LFBO

Navigated through all pages of F-Plan and D-ATIS. F-Plan page loaded correctly and all rendering seemed appropriate. As discussed D-ATIS page still shows "Not yet implemented", but this is expected.

QA Passed

QA Pass

@alepouna
Copy link
Member

Needs a changelog update and we can merge

@heclak
Copy link
Contributor Author

heclak commented Dec 29, 2024

Needs a changelog update and we can merge

@alepouna changelog updated.

@alepouna alepouna requested a review from tracernz December 29, 2024 09:44
.github/CHANGELOG.md Outdated Show resolved Hide resolved
@heclak
Copy link
Contributor Author

heclak commented Jan 11, 2025

fixed the changelog conflict again. could this be merged yet?

@BravoMike99 BravoMike99 merged commit 77296a8 into flybywiresim:master Jan 12, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A380X Related to the A380X aircraft QA A380 Only QA only for A380 required QA Passed
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

7 participants