-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(GPU): Implemented more realistic GPU handling #9470
feat(GPU): Implemented more realistic GPU handling #9470
Conversation
fbw-common/src/systems/shared/src/publishers/Extras/ExtrasSimVarPublisher.ts
Show resolved
Hide resolved
Are you able to also connect the plane to power if the gate doesn't have gp available? (from the efb gpu btn) |
Yes, if that airport supplies a GPU cart then clicking the EFB button will call it. If not then that call wont be answered. That is the current behavior as well so I didnt change that. Btw the testinstructions should tell you that ;) |
I asked for confirmation because specifically there isn't a mention if there is "phantom power" if you like but good to know now 👍 |
Why do we need to use the event bus to toggle the GPU? Can't we just intercept the MSFS K event (with no passthrough so it doesn't go to the sim), and handle it our way? This means it will work for external clients as well e.g. Mobiflight, SPAD etc. |
Hmm, not sure why I didnt think of that. Guess I was really deep into the eventbus and just wanted to use it for it :D |
fbw-a380x/src/systems/instruments/src/SD/Pages/ElecAc/elements/ExternalPower.tsx
Outdated
Show resolved
Hide resolved
Quality Assurance Trainee Report Discord Username : LeDerpLegend
Testing Results: Testing Results: Negatives: Notes: |
Fixes #[issue_no]
Summary of Changes
This PR intends to make the GPU handling on both aircraft more realistic and immersive.
It mainly does that by decoupling the GPU connection state from the MSFS vars.
As a result you will now be able to disconnect the GPU from the plane even when on a powered stand.
I also fixed an issue in the version checker for the a32nx.
In order to facilitate communication from the EFB via the eventbus to the extrashost, I integrated an eventbus instance into the EFB Wrapper
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub):_chaoz_
Testing instructions
Since this PR implements the same function for both planes the tests will be the same:
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.