Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(a380x/lights): add cockpit ambient bounce lights #9442

Merged
merged 16 commits into from
Nov 14, 2024

Conversation

ImenesFBW
Copy link
Contributor

@ImenesFBW ImenesFBW commented Nov 7, 2024

Summary of Changes

Adds soft and wide bounce lights to the cockpit ambient lights to make the cockpit more realistically lit.

Screenshots (if necessary)

OVERHEAD BEFORE/AFTER:
image
image

COCKPIT FRONT BEFORE/AFTER:

image
image

COCKPIT BACK BEFORE/AFTER:

image
image

All pics are taken at full ambient knob setting and with the cabin disabled. And the light color is currently on the warmer side as I kept it the same as the source lights. Since lights will change a lot in MSFS24 further tunning will probably be done for that sim.

References

Additional context

Discord username (if different from GitHub):

Testing instructions

NOTE: Currently there are some cabin light leaks that are tied to the cockpit ambient light switch, that help make the cockpit brighter, you should disable the cabin when comparing to current master to make a more accurate comparison with it. But please test with all plausible configurations.

Needs 776b090 this commit or above from the large-files repo to function properly, as it uses a new light effect.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@C-Schaffhausen
Copy link
Contributor

I feel like it's a bit too much, never seen a cockpit this bright before. Could you show how it looks at half brightness?

@ImenesFBW
Copy link
Contributor Author

ImenesFBW commented Nov 8, 2024

I feel like it's a bit too much, never seen a cockpit this bright before. Could you show how it looks at half brightness?

This is at half.
image

If you have some personal reference photos, or you are able to grab some at different ambient light settings in the cockpit, please send them over, will happily take a look.

@Pruznak
Copy link

Pruznak commented Nov 8, 2024

I like it much more at half, I fell like it looks too artificial at full brightness.

@ImenesFBW
Copy link
Contributor Author

I like it much more at half, I fell like it looks too artificial at full brightness.

I doubt that the knob is set at full setting very often, using the storm light will put it at max. One of the reasons I want to include this before working on the storm light.

@Texagg12
Copy link

Texagg12 commented Nov 8, 2024

If I may add a comment as one of the verified pilots on here. The idea of the storm light is to make it where if you need instant daylight inside the cockpit you get it. Therefore, I'd say from the examples above it looks good. There is a dim-able knob as not to shock the senses but that is not what the storm does.

-DannyTanner

@ImenesFBW ImenesFBW added QA A380 Only QA only for A380 required A380X Related to the A380X aircraft labels Nov 9, 2024
@alepouna alepouna added Lighting Anything related to lighting/lights (ata-33) QA Tier 1 Needs Changelog labels Nov 10, 2024
@2hwk 2hwk removed QA A380 Only QA only for A380 required Needs Changelog labels Nov 10, 2024
@2hwk 2hwk added this to the v0.13.0 milestone Nov 13, 2024
@2hwk
Copy link
Member

2hwk commented Nov 14, 2024

Quality Assurance Report

Discord Username: 2cas
Object of testing: #9442
Aircraft: A380X
Tier of Testing: 1
Date: 14/11/2024

Testing Process:

  • Spawned and adjusted ambient light knob -> Light did not work as elec is not supplied
  • Connected EXT PWR, adjusted ambient light -> observed ambient light as per the screenshots
  • After engine start - Light remains working

Testing Results:
QA Passed

Negatives:

  • N/A

Conclusions:

LGTM

@2hwk 2hwk merged commit 97c401a into flybywiresim:master Nov 14, 2024
8 checks passed
@ImenesFBW ImenesFBW deleted the cockpit-ambient-bounce branch November 14, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A380X Related to the A380X aircraft Lighting Anything related to lighting/lights (ata-33) QA Passed QA Ready to Test QA Tier 1
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

6 participants