-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(a380x/lights): add cockpit ambient bounce lights #9442
Conversation
I feel like it's a bit too much, never seen a cockpit this bright before. Could you show how it looks at half brightness? |
If you have some personal reference photos, or you are able to grab some at different ambient light settings in the cockpit, please send them over, will happily take a look. |
I like it much more at half, I fell like it looks too artificial at full brightness. |
I doubt that the knob is set at full setting very often, using the storm light will put it at max. One of the reasons I want to include this before working on the storm light. |
If I may add a comment as one of the verified pilots on here. The idea of the storm light is to make it where if you need instant daylight inside the cockpit you get it. Therefore, I'd say from the examples above it looks good. There is a dim-able knob as not to shock the senses but that is not what the storm does. -DannyTanner |
Quality Assurance Report Discord Username: 2cas Testing Process:
Testing Results: Negatives:
Conclusions: LGTM |
Summary of Changes
Adds soft and wide bounce lights to the cockpit ambient lights to make the cockpit more realistically lit.
Screenshots (if necessary)
OVERHEAD BEFORE/AFTER:
COCKPIT FRONT BEFORE/AFTER:
COCKPIT BACK BEFORE/AFTER:
All pics are taken at full ambient knob setting and with the cabin disabled. And the light color is currently on the warmer side as I kept it the same as the source lights. Since lights will change a lot in MSFS24 further tunning will probably be done for that sim.
References
Additional context
Discord username (if different from GitHub):
Testing instructions
NOTE: Currently there are some cabin light leaks that are tied to the cockpit ambient light switch, that help make the cockpit brighter, you should disable the cabin when comparing to current master to make a more accurate comparison with it. But please test with all plausible configurations.
Needs 776b090 this commit or above from the large-files repo to function properly, as it uses a new light effect.
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.