Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(a380/mfd): status and switching page #9362

Merged
merged 8 commits into from
Nov 16, 2024

Conversation

Frenkii
Copy link
Contributor

@Frenkii Frenkii commented Nov 3, 2024

Fixes #[issue_no]

Summary of Changes

Creation of the SURV -> STATUS & SWITCHING page.
TCAS 1 is reacting on the TCAS FAULT Simvar.

Screenshots (if necessary)

grafik

References

Additional context

Discord username (if different from GitHub):
frenkii

Testing instructions

  1. Access the Status and Switching page via the SURV menu.
  2. Buttons SYS 1 and 2 should have hover effect but no function.
  3. Set Simvar TCAS fault to 1 -> TCAS 1 should switch to amber color.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page

@Frenkii Frenkii force-pushed the feature/surv-status-switching-page branch from 2d9f889 to 272f2f3 Compare November 6, 2024 19:58
@flogross89
Copy link
Contributor

flogross89 commented Nov 8, 2024

Very nice, thank you! Please notify us when it's ready for review

@Frenkii
Copy link
Contributor Author

Frenkii commented Nov 8, 2024

Basically it's nearly finished.

What do you think? Leave SYS 2 completely in mode "OFF", since it's not implemented?

@Frenkii
Copy link
Contributor Author

Frenkii commented Nov 10, 2024

I decided now to hardcode SYS 2 as OFF.
In general, I am not sure, what's the best way to handle the different status of the systems, but the layout of the page is set up so far.

@Frenkii Frenkii marked this pull request as ready for review November 10, 2024 18:38
@flogross89
Copy link
Contributor

I decided now to hardcode SYS 2 as OFF. In general, I am not sure, what's the best way to handle the different status of the systems, but the layout of the page is set up so far.

That's reasonable, we can connect the other systems when they are implemented

@BravoMike99
Copy link
Contributor

Hi, thanks for the contribution. On the FWS side it currently uses the same variable for TCAS 1 & TCAS 2 fault as there's no two systems as floridude mentioned but I guess its fine to leave your implementation as is (only tcas 1). Also, please add an entry to the changelog.md file :)

@2hwk 2hwk added the A380X Related to the A380X aircraft label Nov 14, 2024
@2hwk 2hwk added this to the v0.13.0 milestone Nov 14, 2024
@2hwk
Copy link
Member

2hwk commented Nov 15, 2024

Needs Testing Instructions

@2hwk
Copy link
Member

2hwk commented Nov 16, 2024

Quality Assurance Tester Report

Discord Username: 2cas
Object of testing: #9362
Aircraft: A380X
Tier of Testing: 1
Date: 16/11/2024

Testing Process:

  • Access the Status and Switching page via the SURV menu.
  • Buttons SYS 1 and 2 should have hover effect but no function.
  • Set Simvar TCAS fault to 1 -> TCAS 1 should switch to amber color.
  • Turned off ADR1 to fault the TCAS computer -> TCAS1 turned amber

Testing Results:
QA Passed

Negatives:

  • N/A

Conclusions:

  • LGTM

@2hwk 2hwk enabled auto-merge (squash) November 16, 2024 05:12
@2hwk 2hwk merged commit dccbd6a into flybywiresim:master Nov 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A380X Related to the A380X aircraft QA Passed QA Tier 1
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

4 participants