fix(a380x/fms): fix DH to ensure value inferior or equal 1 #9120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to resolve issue flybywiresim#9114
thomasshrm
changed the title
thomasshrm
changed the title
thomasshrm
changed the title
|
This only partially addresses #9114 if at all. @thomasshrm the image you tried to provide is not publicly accessible. |
Hi, sorry for the mistake |
2hwk
previously approved these changes
Oct 29, 2024
2hwk
previously approved these changes
Nov 2, 2024
2hwk
added
QA Tier 1
QA A380 Only
|
Please add testing instructions |
tracernz
requested changes
Nov 2, 2024
| @@ -2524,6 +2524,8 @@ export class MfdFmsPerf extends FmsPage<MfdFmsPerfProps> { | |||
| SimVar.SetSimVarValue('L:AIRLINER_DECISION_HEIGHT', 'feet', -1); | |||
| } else if (v === null) { | |||
| SimVar.SetSimVarValue('L:AIRLINER_DECISION_HEIGHT', 'feet', -2); | |||
| } else if (v > 1) { | |||
| SimVar.SetSimVarValue('L:AIRLINER_DECISION_HEIGHT', 'feet', -1); | |||
There was a problem hiding this comment.
This does not do what was intended at all, and will actually totally break the minima.
There was a problem hiding this comment.
Agree, we must not merge the PR in the current state
2hwk
added
Waiting For Response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially Fixes 9114
Summary of Changes
Adding a check to ensure the value can't be superior to 1
Screenshots (if necessary)
References
https://private-user-images.githubusercontent.com/58574351/378502108-66cea740-d823-4c28-8f8b-9c4dbf7a02af.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mjk2MTMyNDUsIm5iZiI6MTcyOTYxMjk0NSwicGF0aCI6Ii81ODU3NDM1MS8zNzg1MDIxMDgtNjZjZWE3NDAtZDgyMy00YzI4LThmOGItOWM0ZGJmN2EwMmFmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDEwMjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQxMDIyVDE2MDIyNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTlhY2Q1YTZkZWJhMzUyMDgyZDY3MjZmNDhlZDU2ODYzZTQ3YTI2ZmQxNWQ1NTYwNWVlMzZhMmNiMDk1MTA5NmEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.CJWBl_JJON4t_9HWIkaXrvLnqJGCXKnpZxjHTTawpBI
Additional context
Discord username (if different from GitHub): tommytknuckles
Testing instructions
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.