-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Arinc429-LVar-Bridge #8631
Open
frankkopp
wants to merge
25
commits into
flybywiresim:master
Choose a base branch
from
frankkopp:lvar-api-provider
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankkopp
force-pushed
the
lvar-api-provider
branch
from
April 20, 2024 20:27
0d24d41
to
13132a3
Compare
frankkopp
force-pushed
the
lvar-api-provider
branch
4 times, most recently
from
April 27, 2024 16:46
9fcec36
to
f9068d0
Compare
frankkopp
force-pushed
the
lvar-api-provider
branch
from
June 14, 2024 18:01
c219947
to
cc0874c
Compare
frankkopp
force-pushed
the
lvar-api-provider
branch
from
September 22, 2024 21:07
b93bacf
to
869440c
Compare
frankkopp
force-pushed
the
lvar-api-provider
branch
from
November 8, 2024 21:46
40db3f1
to
5d3b454
Compare
frankkopp
force-pushed
the
lvar-api-provider
branch
from
December 2, 2024 11:41
5d3b454
to
8762f3d
Compare
frankkopp
force-pushed
the
lvar-api-provider
branch
from
December 27, 2024 23:00
8762f3d
to
020829d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
As the goal for the internal systems of the A32NX (and also the A380X) is to use data exchange protocols and formats as in the real aircraft it might become necessary to introduce a way to still expose the raw values of these LVars to 3rd parties (e.g. cockpit builders, 3rd party add-ons/applications) .
This PR is a proof of concept for such a arinc429-to-raw-lvar-bridge.
One of the main concern is the impact on performance (fps) of the simulator.
Another aspect is how to make this configurable for end users.
Discord username (if different from GitHub): cdr_maverick
Current Version
This now uses a list of LVars maintained by devs which will be copied into a list of vars in the "work" folder.
This work list can be edited by the user to add a "-" in front of a LVar to not convert it.
The user could add variables to it and and any missing variables will be re-added from the default list.
These few hundred vars have barely any impact as can be seen in the screen shot - 219 vars in 8 microsecs
Preliminary PoC findings
Performance without any special optimizations:
That is ~62microsecs (trimmed average) per tick with 1768 LVars per tick and this code:
Testing instructions
TBD
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.