feat(a380x): Add legacy FWS, GPWS from A32NX implementation #8439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 560c316)
2hwk
requested changes
Jan 31, 2024
tracernz
previously requested changes
Feb 8, 2024
tracernz
reviewed
Feb 8, 2024
tracernz
reviewed
Feb 14, 2024
2hwk
approved these changes
Feb 17, 2024
flogross89
dismissed
tracernz’s stale review
See comment, callouts were defined based on video references from Emirates A380.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purely for A380X, no QA needed.
Summary of Changes
Adds the current implementation of FWS and GPWS from the A32NX for use in the A380X. Instead of A32NX_Core, SystemsHost is used this time.
The FWS is going to be superseded by #4872 .
Screenshots (if necessary)
none
References
A32NX codebase,
https://www.youtube.com/watch?v=YySD1QL5b0Y
https://www.youtube.com/watch?v=UGtzwn5yXSU
Additional context
Tested on my sim, works as expected.
Discord username (if different from GitHub):
Testing instructions
The following callouts should be made:
2500, 1000, 400, 300, 200, 100, 50, 40, 30, 20, (10, 5) + 100 above + minimums
(this represents the assumed default configuration for Emirates. Customization should be possible via the EFB)
How to download the PR for QA
Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.