Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable storage server to serve https #967

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

kvmw
Copy link

@kvmw kvmw commented Nov 24, 2022

Enables https on storage server by setting storage-https-enabled flag and passing storage-cert-path.

  • storage-https-enabled is a bool, defaults to false
  • storage-cert-path is a directory containing tls.crt (certificate) and tls.key (private key). It can be a Secret volume in k8s env.

@kvmw kvmw marked this pull request as draft November 24, 2022 16:31
@kvmw kvmw marked this pull request as ready for review November 24, 2022 16:47
@pjbgf
Copy link
Member

pjbgf commented Dec 4, 2022

@kvmw Thank you very much for your PR.

This topic came up in the Flux dev meeting a few weeks ago, so I created a RFC to formalise what we believe an implementation should look like. Some details are still up for debate, so I would ask you to engage on that PR in case you agree/disagree with the approach.

Once the RFC is in an implementable state, this PR could be the source controller implementation.

@pjbgf pjbgf added the area/security Security related issues and pull requests label Dec 4, 2022
@stefanprodan stefanprodan added the blocked/needs-validation Requires wider review and validation label Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/security Security related issues and pull requests blocked/needs-validation Requires wider review and validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants