-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proxy support for Azure buckets #1567
Conversation
bbde481
to
de80b99
Compare
de80b99
to
f8820cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @matheuscscp 🏅
f8820cc
to
0d7f335
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks.
I'm trying an attempt to test at least the proxy integration with a mock server here, will update the PR with the results. |
0d7f335
to
b61cfb0
Compare
Signed-off-by: Matheus Pimenta <[email protected]>
b61cfb0
to
b6bd2ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the proxy test.
LGTM!
Part of #1563
I was able to manually test this using a Blob SAS Token in my personal Azure account.