Update fluxcd/pkg deps and k8s deps to 1.31.1 #931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheuscscp
approved these changes
Sep 25, 2024
darkowlzz
changed the title
stefanprodan
requested changes
Sep 25, 2024
darkowlzz
commented
Sep 25, 2024
| github.com/fluxcd/pkg/git v0.20.0 | ||
| github.com/fluxcd/pkg/apis/event v0.10.1 | ||
| github.com/fluxcd/pkg/apis/meta v1.6.1 | ||
| github.com/fluxcd/pkg/git v0.21.0 |
There was a problem hiding this comment.
The CI failed because the following gets added to go.mod
go 1.22.4
toolchain go1.23.1After closer inspection by updating the packages one by one, this happens only when pkg/git is updated. Looking at pkg/git's go.mod, there's go 1.22.4 in the mod file https://github.com/fluxcd/pkg/blob/30c101fc7c9fac4d84937ff4890a3da46a9db2dd/git/go.mod#L3. Everywhere else, I believe we have it to 1.22.0.
pkg/git is also imported in SC but there we didn't need such a change.
After try a few things, it seems updating the go version in the go.mod file removes the need for toolchain. This is what SC has it, go 1.22.5.
darkowlzz
force-pushed
the
deps-update
branch
from
e80a62c to
afbab29
Compare
Signed-off-by: Sunny <[email protected]>
darkowlzz
force-pushed
the
deps-update
branch
from
afbab29 to
7407570
Compare
|
CI failures have been resolved and also updated the api package. Should be good now. |
stefanprodan
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.