Fix telegram test flake #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheuscscp
reviewed
Aug 1, 2024
The test would sometimes fail because the metadata lines are built from a map and map iteration order in Go is non-deterministic. Therefore, the lines may be ordered differently between different test runs. Now, the test sorts the metadata lines of the telegram message so they are always the same and only then verifies the expected output. closes #867 Signed-off-by: Max Jonas Werner <[email protected]>
makkes
force-pushed
the
fix-telegram-test
branch
from
5078a7f to
f9610af
Compare
stefanprodan
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test would sometimes fail because the metadata lines are built from a map and map iteration order in Go is non-deterministic. Therefore, the lines may be ordered differently between different test runs.
Now, the test sorts the metadata lines of the telegram message so they are always the same and only then verifies the expected output.
closes #867