Replace whilp/git-urls module by chainguard-dev/git-urls #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
reviewed
Dec 5, 2023
There was a problem hiding this comment.
The hard coded limit in this project is less than our own limit of 2048, which we already enforced in #654 (and in the further validation of the URL field within the API object itself).
Given this, we can not just merge this without it breaking backwards compatibility with existing validation rules (which arguably are too wide, but I have seen weird URLs in corporate environments).
|
@hiddeco I don't see why we couldn't bump that limit to 2048 on our side. Let me handle that change and publish a new release. |
hectorj2f
force-pushed
the
replace_go_module
branch
from
4a2279a to
f921722
Compare
cpanato
approved these changes
Dec 6, 2023
|
@hectorj2f can you please run |
hiddeco
force-pushed
the
replace_go_module
branch
2 times, most recently
from
e9ca446 to
befca49
Compare
Signed-off-by: Hector Fernandez <[email protected]>
hiddeco
force-pushed
the
replace_go_module
branch
from
befca49 to
39a3853
Compare
|
Successfully created backport PR for |
|
Thanks for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discovered a vulnerability on the module
github.com/whilp/git-urlsGHSA-3f2q-6294-fmq5. This repository doesn't look to be maintained at this moment. That is why we decided to fix the vulnerability and move the repository over our organization. We plan to maintain this repository in the future.