[RFC-0008] Custom Event Metadata from Annotations #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheuscscp
force-pushed
the
rfc-0008
branch
4 times, most recently
from
05976ac to
311fa14
Compare
matheuscscp
commented
Dec 25, 2024
Comment on lines
-171
to
+183
| app.kubernetes.io/env: "production" | ||
| app.kubernetes.io/cluster: "my-cluster" | ||
| app.kubernetes.io/region: "us-east-1" | ||
| env: production | ||
| cluster: my-cluster | ||
| region: us-east-1 |
There was a problem hiding this comment.
I'm removing the app.kubernetes.io/ prefix here since it has little effect and may cause confusion in the presence of other prefixes the user may need to understand for the Alert API, e.g. event.toolkit.fluxcd.io/.
matheuscscp
force-pushed
the
rfc-0008
branch
from
311fa14 to
caee223
Compare
Signed-off-by: Matheus Pimenta <[email protected]>
matheuscscp
force-pushed
the
rfc-0008
branch
from
caee223 to
9bdc215
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: fluxcd/flux2#4809
The most significant change in this PR for implementing RFC 0008 is moving the group prefix removal from the
cleanupMetadata()function deeper into the request handling logic, such that the precedence order defined in the RFC can be concisely implemented in a single place. This is because different Alert objects matching an event may append different Alert-level metadata to the event, and hence for the metadata combination, precedence order and key conflict detection to be implemented in a single place, moving the group prefix removal deeper was necessary. This logic is now implemented by the functioncombineEventMetadata(), which is an evolution of the renamedenhanceEventWithAlertMetadata(). As a result, a few other functions manipulating metadata keys now have to consider the involved object group prefix when doing so.Tasks:
Groupfromgithub.com/fluxcd/pkg/apis/eventafter [RFC-0008] Custom Event Metadata from Annotations pkg#848 is merged and the version can be bumped.