misc: take errs into account

Signed-off-by: Hidde Beydals <[email protected]>
fluxcd · Oct 11, 2023 · edb6a54 · edb6a54
1 parent bdda580
commit edb6a54
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/internal/server/event_server.go b/internal/server/event_server.go
@@ -114,7 +114,11 @@ func (s *EventServer) eventMiddleware(h http.Handler) http.Handler {
 			w.WriteHeader(http.StatusBadRequest)
 			return
 		}
-		r.Body.Close()
+		if err := r.Body.Close(); err != nil {
+			s.logger.Error(err, "closing the request body failed")
+			w.WriteHeader(http.StatusBadRequest)
+			return
+		}
 		r.Body = io.NopCloser(bytes.NewBuffer(body))
 
 		event := &eventv1.Event{}

diff --git a/internal/server/receiver_handler_test.go b/internal/server/receiver_handler_test.go
@@ -677,7 +677,7 @@ func Test_handlePayload(t *testing.T) {
 			g.Expect(rr.Result().StatusCode).To(gomega.Equal(tt.expectedResponseCode))
 
 			var allReceivers apiv1.ReceiverList
-			err = client.List(context.TODO(), &allReceivers)
+			g.Expect(client.List(context.TODO(), &allReceivers)).To(gomega.Succeed())
 
 			var annotatedResources int
 			for _, obj := range allReceivers.Items {