-
Notifications
You must be signed in to change notification settings - Fork 137
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix flaky test related to patching finalizer
In the TestAlertReconciler and TestProviderReconciler migration to static object tests, the objects are patched with specific finalizers and checked if they get removed by the migration reconciler. The test set up step, that doesn't involve the reconciler, results in a timeout waiting for the patched finalizer to appear on the object. Increasing the timeout doesn't help. Updating the object, instead of patching works around this issue. A similar issue has been observed in fluxcd/pkg/runtime/patch package tests where the patching behavior is tested, likely related to finalizers, result in flaky tests. Signed-off-by: Sunny <[email protected]>
- Loading branch information
Showing
2 changed files
with
32 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters