Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify precedence in Kustomization substituteFrom #1301

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

srgvg
Copy link
Contributor

@srgvg srgvg commented Dec 6, 2024

No description provided.

@stefanprodan stefanprodan added the area/docs Documentation related issues and pull requests label Dec 6, 2024
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @srgvg

@stefanprodan stefanprodan merged commit 3791888 into fluxcd:main Dec 6, 2024
6 checks passed
@srgvg
Copy link
Contributor Author

srgvg commented Dec 11, 2024

This PR was initially done after reaching a first concensus in this Slack conversation.

During later testing I noticed however the other behavior.
Checking the underlying code here seems to confirm this:

last in the list overwrites previous values.

Can a maintainer confirm?

@srgvg
Copy link
Contributor Author

srgvg commented Dec 11, 2024

see fluxcd/flux2#5109 for follow-up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants