Remove deprecated object metrics #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hasithsen you need signoff all your commits, see the DCO instructions here: https://github.com/fluxcd/image-reflector-controller/pull/677/checks?check_run_id=34108752768 |
darkowlzz
changed the title
darkowlzz
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Thanks for working on this.
Before:
# HELP gotk_reconcile_condition The current condition status of a GitOps Toolkit resource reconciliation.
# TYPE gotk_reconcile_condition gauge
gotk_reconcile_condition{kind="ImageRepository",name="podinfo",namespace="default",status="False",type="Ready"} 0
gotk_reconcile_condition{kind="ImageRepository",name="podinfo",namespace="default",status="True",type="Ready"} 1
gotk_reconcile_condition{kind="ImageRepository",name="podinfo",namespace="default",status="Unknown",type="Ready"} 0
# HELP gotk_reconcile_duration_seconds The duration in seconds of a GitOps Toolkit resource reconciliation.
# TYPE gotk_reconcile_duration_seconds histogram
gotk_reconcile_duration_seconds_bucket{kind="ImageRepository",name="podinfo",namespace="default",le="0.01"} 0
gotk_reconcile_duration_seconds_bucket{kind="ImageRepository",name="podinfo",namespace="default",le="0.038363583488692544"} 0
gotk_reconcile_duration_seconds_bucket{kind="ImageRepository",name="podinfo",namespace="default",le="0.1471764538093883"} 1
gotk_reconcile_duration_seconds_bucket{kind="ImageRepository",name="podinfo",namespace="default",le="0.5646216173286169"} 1
gotk_reconcile_duration_seconds_bucket{kind="ImageRepository",name="podinfo",namespace="default",le="2.166090855590701"} 1
gotk_reconcile_duration_seconds_bucket{kind="ImageRepository",name="podinfo",namespace="default",le="8.309900738254731"} 2
gotk_reconcile_duration_seconds_bucket{kind="ImageRepository",name="podinfo",namespace="default",le="31.879757075478317"} 2
gotk_reconcile_duration_seconds_bucket{kind="ImageRepository",name="podinfo",namespace="default",le="122.30217221643493"} 2
gotk_reconcile_duration_seconds_bucket{kind="ImageRepository",name="podinfo",namespace="default",le="469.19495946736544"} 2
gotk_reconcile_duration_seconds_bucket{kind="ImageRepository",name="podinfo",namespace="default",le="1799.9999999999986"} 2
gotk_reconcile_duration_seconds_bucket{kind="ImageRepository",name="podinfo",namespace="default",le="+Inf"} 2
gotk_reconcile_duration_seconds_sum{kind="ImageRepository",name="podinfo",namespace="default"} 2.475601911
gotk_reconcile_duration_seconds_count{kind="ImageRepository",name="podinfo",namespace="default"} 2
# HELP gotk_suspend_status The current suspend status of a GitOps Toolkit resource.
# TYPE gotk_suspend_status gauge
gotk_suspend_status{kind="ImageRepository",name="podinfo",namespace="default"} 0
After:
# HELP gotk_reconcile_duration_seconds The duration in seconds of a GitOps Toolkit resource reconciliation.
# TYPE gotk_reconcile_duration_seconds histogram
gotk_reconcile_duration_seconds_bucket{kind="ImageRepository",name="podinfo",namespace="default",le="0.01"} 0
gotk_reconcile_duration_seconds_bucket{kind="ImageRepository",name="podinfo",namespace="default",le="0.038363583488692544"} 0
gotk_reconcile_duration_seconds_bucket{kind="ImageRepository",name="podinfo",namespace="default",le="0.1471764538093883"} 1
gotk_reconcile_duration_seconds_bucket{kind="ImageRepository",name="podinfo",namespace="default",le="0.5646216173286169"} 1
gotk_reconcile_duration_seconds_bucket{kind="ImageRepository",name="podinfo",namespace="default",le="2.166090855590701"} 1
gotk_reconcile_duration_seconds_bucket{kind="ImageRepository",name="podinfo",namespace="default",le="8.309900738254731"} 1
gotk_reconcile_duration_seconds_bucket{kind="ImageRepository",name="podinfo",namespace="default",le="31.879757075478317"} 1
gotk_reconcile_duration_seconds_bucket{kind="ImageRepository",name="podinfo",namespace="default",le="122.30217221643493"} 1
gotk_reconcile_duration_seconds_bucket{kind="ImageRepository",name="podinfo",namespace="default",le="469.19495946736544"} 1
gotk_reconcile_duration_seconds_bucket{kind="ImageRepository",name="podinfo",namespace="default",le="1799.9999999999986"} 1
gotk_reconcile_duration_seconds_bucket{kind="ImageRepository",name="podinfo",namespace="default",le="+Inf"} 1
gotk_reconcile_duration_seconds_sum{kind="ImageRepository",name="podinfo",namespace="default"} 0.040125939
gotk_reconcile_duration_seconds_count{kind="ImageRepository",name="podinfo",namespace="default"} 1
LGTM!
hasithsen
force-pushed
the
main
branch
3 times, most recently
from
43685d0 to
ff7cfc1
Compare
…5083 Signed-off-by: hasithsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suspend and readiness metrics recording removed from ImageRepository and ImagePolicy reconcilers.
Refer fluxcd/flux2#5083.