-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC-0009] Custom Health Checks using CEL expressions #5151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprodan
force-pushed
the
rfc-custom-health-checks
branch
from
January 17, 2025 09:14
0785c3c
to
b6330c1
Compare
…ion Language(CEL) Signed-off-by: Soule BA <[email protected]>
stefanprodan
force-pushed
the
rfc-custom-health-checks
branch
from
January 17, 2025 09:15
b6330c1
to
9b5e70c
Compare
Signed-off-by: Stefan Prodan <[email protected]>
stefanprodan
force-pushed
the
rfc-custom-health-checks
branch
2 times, most recently
from
January 17, 2025 09:45
0cdd996
to
76153fc
Compare
Signed-off-by: Stefan Prodan <[email protected]>
stefanprodan
force-pushed
the
rfc-custom-health-checks
branch
from
January 17, 2025 09:49
76153fc
to
f604d7f
Compare
souleb
reviewed
Jan 17, 2025
Signed-off-by: Stefan Prodan <[email protected]>
souleb
reviewed
Jan 17, 2025
stefanprodan
force-pushed
the
rfc-custom-health-checks
branch
from
January 17, 2025 10:27
15d2789
to
8eec794
Compare
Signed-off-by: Stefan Prodan <[email protected]>
stefanprodan
force-pushed
the
rfc-custom-health-checks
branch
from
January 17, 2025 10:40
8eec794
to
6f6d3fb
Compare
souleb
reviewed
Jan 17, 2025
stefanprodan
force-pushed
the
rfc-custom-health-checks
branch
2 times, most recently
from
January 17, 2025 13:32
91ce112
to
603adf9
Compare
souleb
reviewed
Jan 17, 2025
stefanprodan
force-pushed
the
rfc-custom-health-checks
branch
2 times, most recently
from
January 17, 2025 14:41
76a42dd
to
f9d2fbe
Compare
Signed-off-by: Stefan Prodan <[email protected]>
stefanprodan
force-pushed
the
rfc-custom-health-checks
branch
from
January 17, 2025 14:49
f9d2fbe
to
74d748f
Compare
souleb
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Will review next week. |
matheuscscp
reviewed
Jan 21, 2025
Co-authored-by: Matheus Pimenta <[email protected]> Signed-off-by: Stefan Prodan <[email protected]>
matheuscscp
reviewed
Jan 22, 2025
matheuscscp
force-pushed
the
rfc-custom-health-checks
branch
from
January 23, 2025 08:33
de242d8
to
f95922a
Compare
matheuscscp
force-pushed
the
rfc-custom-health-checks
branch
2 times, most recently
from
January 23, 2025 08:35
75a0263
to
856e2c7
Compare
matheuscscp
approved these changes
Jan 23, 2025
matheuscscp
force-pushed
the
rfc-custom-health-checks
branch
from
January 23, 2025 08:39
856e2c7
to
65cd6da
Compare
stefanprodan
changed the title
[RFC] Custom Health Checks using CEL expressions
[RFC-0009] Custom Health Checks using CEL expressions
Jan 23, 2025
matheuscscp
force-pushed
the
rfc-custom-health-checks
branch
from
January 23, 2025 09:22
65cd6da
to
1b2a3aa
Compare
This was referenced Jan 23, 2025
makkes
reviewed
Jan 30, 2025
Signed-off-by: Matheus Pimenta <[email protected]>
matheuscscp
force-pushed
the
rfc-custom-health-checks
branch
from
January 31, 2025 09:14
45bb2a7
to
9e6f723
Compare
makkes
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This RFC proposes to extend the Flux
Kustomization
API with custom health checks for custom resources using the Common Expression Language (CEL).Goals
Based on #4528