Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC-0009] Custom Health Checks using CEL expressions #5151

Merged
merged 8 commits into from
Jan 31, 2025

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Jan 17, 2025

This RFC proposes to extend the Flux Kustomization API with custom health checks for custom resources using the Common Expression Language (CEL).

Goals

  • Provide a generic solution for users to customise the health check evaluation of custom resources.
  • Provide a space for the community to contribute custom health checks for popular custom resources.

Based on #4528

@stefanprodan stefanprodan added the area/rfc Feature request proposals in the RFC format label Jan 17, 2025
@stefanprodan stefanprodan force-pushed the rfc-custom-health-checks branch from 0785c3c to b6330c1 Compare January 17, 2025 09:14
@stefanprodan stefanprodan force-pushed the rfc-custom-health-checks branch 2 times, most recently from 0cdd996 to 76153fc Compare January 17, 2025 09:45
@stefanprodan stefanprodan force-pushed the rfc-custom-health-checks branch from 76153fc to f604d7f Compare January 17, 2025 09:49
Signed-off-by: Stefan Prodan <[email protected]>
@stefanprodan stefanprodan force-pushed the rfc-custom-health-checks branch from 15d2789 to 8eec794 Compare January 17, 2025 10:27
Signed-off-by: Stefan Prodan <[email protected]>
@stefanprodan stefanprodan force-pushed the rfc-custom-health-checks branch from 8eec794 to 6f6d3fb Compare January 17, 2025 10:40
rfcs/0000-custom-health-checks/README.md Outdated Show resolved Hide resolved
rfcs/0000-custom-health-checks/README.md Outdated Show resolved Hide resolved
@stefanprodan stefanprodan force-pushed the rfc-custom-health-checks branch 2 times, most recently from 91ce112 to 603adf9 Compare January 17, 2025 13:32
rfcs/0000-custom-health-checks/README.md Outdated Show resolved Hide resolved
rfcs/0000-custom-health-checks/README.md Outdated Show resolved Hide resolved
@stefanprodan stefanprodan force-pushed the rfc-custom-health-checks branch 2 times, most recently from 76a42dd to f9d2fbe Compare January 17, 2025 14:41
@stefanprodan stefanprodan force-pushed the rfc-custom-health-checks branch from f9d2fbe to 74d748f Compare January 17, 2025 14:49
Copy link
Member

@souleb souleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@matheuscscp
Copy link
Member

Will review next week.

rfcs/0000-custom-health-checks/README.md Outdated Show resolved Hide resolved
rfcs/0000-custom-health-checks/README.md Outdated Show resolved Hide resolved
rfcs/0000-custom-health-checks/README.md Outdated Show resolved Hide resolved
rfcs/0000-custom-health-checks/README.md Outdated Show resolved Hide resolved
rfcs/0000-custom-health-checks/README.md Outdated Show resolved Hide resolved
rfcs/0000-custom-health-checks/README.md Outdated Show resolved Hide resolved
rfcs/0000-custom-health-checks/README.md Outdated Show resolved Hide resolved
rfcs/0000-custom-health-checks/README.md Outdated Show resolved Hide resolved
rfcs/0000-custom-health-checks/README.md Outdated Show resolved Hide resolved
rfcs/0000-custom-health-checks/README.md Outdated Show resolved Hide resolved
Co-authored-by: Matheus Pimenta <[email protected]>
Signed-off-by: Stefan Prodan <[email protected]>
@matheuscscp matheuscscp force-pushed the rfc-custom-health-checks branch from de242d8 to f95922a Compare January 23, 2025 08:33
@matheuscscp matheuscscp force-pushed the rfc-custom-health-checks branch 2 times, most recently from 75a0263 to 856e2c7 Compare January 23, 2025 08:35
@matheuscscp matheuscscp force-pushed the rfc-custom-health-checks branch from 45bb2a7 to 9e6f723 Compare January 31, 2025 09:14
@stefanprodan stefanprodan merged commit cfd369d into main Jan 31, 2025
6 checks passed
@stefanprodan stefanprodan deleted the rfc-custom-health-checks branch January 31, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/rfc Feature request proposals in the RFC format
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants