Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NaN Cluster Stats Dashboard #24

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mjtrangoni
Copy link
Contributor

Hi @darkowlzz,

related to #22, I gave it a try it seems to work as expected. JFTR, I also updated to the latest Grafana format by 10.2.x.

Thank you

Signed-off-by: Mario Trangoni <[email protected]>
"exemplar": true,
"expr": "sum(rate(gotk_reconcile_duration_seconds_sum{namespace=~\"$operator_namespace\",exported_namespace=~\"$namespace\",kind=~\"GitRepository|HelmRepository|Bucket|OCIRepository\"}[5m])) by (kind)\n/\n sum(rate(gotk_reconcile_duration_seconds_count{namespace=~\"$operator_namespace\",exported_namespace=~\"$namespace\",kind=~\"GitRepository|HelmRepository|Bucket|OCIRepository\"}[5m])) by (kind)",
"expr": "sum(rate(gotk_reconcile_duration_seconds_sum{namespace=~\"$operator_namespace\",exported_namespace=~\"$namespace\",kind=~\"GitRepository|HelmRepository|Bucket|OCIRepository\"}[5m])) by (kind)\n/\n sum(rate(gotk_reconcile_duration_seconds_count{namespace=~\"$operator_namespace\",exported_namespace=~\"$namespace\",kind=~\"GitRepository|HelmRepository|Bucket|OCIRepository\"}[5m])>0) by (kind)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the "Cluster reconciliation duration" and "Source acquisition duration" panels below also be updated likewise?

@@ -358,21 +366,30 @@
"text": {},
"valueMode": "color"
},
"pluginVersion": "10.0.3",
"pluginVersion": "10.2.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also updated to the latest Grafana format by 10.2.x.

Wouldn't such grafana format updates apply to the other dashboards too? It may be better to update all the dashboards together separately and keep this PR more focused to fixing the bug.

@kingdonb
Copy link
Member

Hey @mjtrangoni have you seen the comments from @darkowlzz

Can you separate out the plugin version update, or is it dependent for some reason?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants