Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Copy slowStartConfig for Gloo upstreams #1455

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

nickcaballero
Copy link
Contributor

Now that Gloo supports Envoy's slow start mode (solo-io/gloo#7810), this PR ensures that slowStartConfig is copied to the generated upstreams.

pkg/apis/gloo/gloo/v1/types.go Outdated Show resolved Hide resolved
pkg/apis/gloo/gloo/v1/types.go Outdated Show resolved Hide resolved
@stefanprodan
Copy link
Member

Can you also update the Gloo version in e2e tests to latest stable please? It's here https://github.com/fluxcd/flagger/blob/main/test/gloo/install.sh#L5

@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.09 🎉

Comparison is base (317d53a) 54.42% compared to head (11f8927) 54.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1455      +/-   ##
==========================================
+ Coverage   54.42%   54.52%   +0.09%     
==========================================
  Files          84       84              
  Lines       10049    10143      +94     
==========================================
+ Hits         5469     5530      +61     
- Misses       3925     3956      +31     
- Partials      655      657       +2     
Impacted Files Coverage Δ
pkg/router/gloo.go 68.64% <0.00%> (+0.51%) ⬆️

... and 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nickcaballero
Copy link
Contributor Author

nickcaballero commented Jul 7, 2023

@stefanprodan Regarding failed test run:

I created the DoubleValue type based on the fact that there was already a Duration type, both of which model the API reference from Gloo. However, when looking at the Gloo CRD, DoubleValue and Duration are expressed as number and string respectively. I was able to confirm that the existing types using Duration don't actually parse correctly either.

I'm going to update the double/duration types to the Go primitives instead for the SlowStartConfig, but I suspect the same change is necessary for the existing types to work (ConnectionConfig specifically, which makes use of Duration in various places).

@aryan9600
Copy link
Member

@nickcaballero could you please squash and rebase on main? should be good to merge after that

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@aryan9600 aryan9600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks @nickcaballero 🎖️

@aryan9600 aryan9600 merged commit 440b881 into fluxcd:main Jul 13, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants