Add gatewayRef port to Canary CRD #1453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @adleong for raising this PR! i guess we must've missed this since the field is experimental and not part of the standard Gateway API CRDs. could you also add this field to |
|
Thanks for the review, @aryan9600! done! |
aryan9600
approved these changes
Jul 4, 2023
Signed-off-by: Alex Leong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Gateway API allows port to be specified as part of the ParentReference of an HttpRoute: https://gateway-api.sigs.k8s.io/references/spec/#gateway.networking.k8s.io%2fv1beta1.ParentReference
Correspondingly, we should be able to specify a port as part of the gatewayRef in a Canary resource.
This field is already copied over to the parentRef of the HttpRoute resource managed by Flagger, all that is required is to add this field to the Canary CRD so that it can be set on Canary resources.