rfc20: add optional attributes key under scheduling #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongahn
force-pushed
the
rfc20-queue
branch
2 times, most recently
from
e667df2 to
d0d9e4b
Compare
|
Made changes per Issue #240 |
grondo
approved these changes
Jun 6, 2020
SteVwonder
reviewed
Jun 9, 2020
spec_20.rst
Outdated
| @@ -100,12 +100,16 @@ Resource Set Format Definition | |||
| The JSON documents that conform to the *R* format SHALL be referred | |||
| to as *R* JSON documents or in short *R* documents. | |||
| An *R* JSON document SHALL consist of a dictionary with three | |||
There was a problem hiding this comment.
Suggested change
| An *R* JSON document SHALL consist of a dictionary with three | |
| An *R* JSON document SHALL consist of a dictionary with four |
There was a problem hiding this comment.
Ah... good catch. Just forced a push.
Problem: there is currently no way for a scheduler to emit opaque information specific to the scheduler itself. For example, as part of resource restruction work within Fluxion, a need arose to emit the queue name into RV1 so that when a multi-queue-capable Fluxion module is reloaded, each currently running job can be enqueued into the corresponding queue. Introduce the "attributes" at the top level which can have the "system" key to contain system specific information pertaining to the creation of this R document. W/ this change, Fluxion can now stick the queue name to "attributes.system.scheduler" and fetch this back to reconstruct its reconstruction correctly.
SteVwonder
approved these changes
Jun 9, 2020
|
Thanks @SteVwonder and @grondo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: rfc20 is current written:
"The scheduling key allows RFC4-compliant schedulers
to serialize any subset of graph resource data into
its value and later deserialize this value
with no data loss. The scheduling key contains
a dictionary with a single key: graph.
Other keys are reserved for future extensions."
As such, we can't add addition keys under the
scheduling key.
As part of resource restruction work within fluxion,
we need to embed the queue name into RV1 so that
when fluxion qmanager is reloaded, it can
enqueue each currently running jobs into
the correct queue.
W/ this proposal, we can stick the queue name
to
scheduling.attributes.system.queue.