remove dumpYaml - was not a good idea anyway

Signed-off-by: vsoch <[email protected]>

controllers/core/core.go

@@ -22,17 +22,13 @@ var (
 )
 
 // SetupControllers sets up all controllers.
-func SetupControllers(mgr ctrl.Manager, restClient rest.Interface, dumpYaml string) (string, error) {
+func SetupControllers(mgr ctrl.Manager, restClient rest.Interface) (string, error) {
 
 	jobReconciler := controllers.NewMiniClusterReconciler(
 		mgr.GetClient(),
 		mgr.GetScheme(),
 		*(mgr.GetConfig()),
 		restClient,
-
-		// Directory to write namespaced yaml to
-		dumpYaml,
-
 		// other watching reconcilers could be added here!
 	)
 

controllers/flux/minicluster_controller.go

@@ -39,7 +39,6 @@ type MiniClusterReconciler struct {
 	client.Client
 	Scheme     *runtime.Scheme
 	Manager    ctrl.Manager
-	DumpYaml   string
 	log        logr.Logger
 	watchers   []MiniClusterUpdateWatcher
 	RESTClient rest.Interface
@@ -51,14 +50,12 @@ func NewMiniClusterReconciler(
 	scheme *runtime.Scheme,
 	restConfig rest.Config,
 	restClient rest.Interface,
-	dumpYaml string,
 	watchers ...MiniClusterUpdateWatcher,
 ) *MiniClusterReconciler {
 
 	return &MiniClusterReconciler{
 		log:        ctrl.Log.WithName("minicluster-reconciler"),
 		Client:     client,
-		DumpYaml:   dumpYaml,
 		Scheme:     scheme,
 		watchers:   watchers,
 		RESTClient: restClient,

main.go

@@ -53,10 +53,8 @@ func main() {
 	var probeAddr string
 
 	// Don't actually create resources, just dump the yaml configs
-	var dumpYaml string
 	flag.StringVar(&metricsAddr, "metrics-bind-address", ":8080", "The address the metric endpoint binds to.")
 	flag.StringVar(&probeAddr, "health-probe-bind-address", ":8081", "The address the probe endpoint binds to.")
-	flag.StringVar(&dumpYaml, "dump-yaml", "", "dump minicluster contents (Job, ConfigMap, etc.) to a YAML files in this directory (must exist)")
 
 	flag.BoolVar(&enableLeaderElection, "leader-elect", false,
 		"Enable leader election for controller manager. "+
@@ -108,7 +106,7 @@ func main() {
 		setupLog.Error(err, "unable to create REST client", "controller", restClient)
 	}
 
-	if failedCtrl, err := core.SetupControllers(mgr, restClient, dumpYaml); err != nil {
+	if failedCtrl, err := core.SetupControllers(mgr, restClient); err != nil {
 		setupLog.Error(err, "Unable to create controller", "controller", failedCtrl)
 		os.Exit(1)
 	}