Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve error message on invalid formatting of shell options #6680

Merged
merged 2 commits into from
Mar 4, 2025

improve error message on invalid formatting of shell options

5acc90d
Select commit
Loading
Failed to load commit list.
Merged

improve error message on invalid formatting of shell options #6680

improve error message on invalid formatting of shell options
5acc90d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 4, 2025 in 0s

83.87% (+0.01%) compared to 621c7b8

View this Pull Request on Codecov

83.87% (+0.01%) compared to 621c7b8

Details

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.87%. Comparing base (621c7b8) to head (5acc90d).

Files with missing lines Patch % Lines
src/bindings/python/flux/cli/base.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6680      +/-   ##
==========================================
+ Coverage   83.85%   83.87%   +0.01%     
==========================================
  Files         534      534              
  Lines       88931    88937       +6     
==========================================
+ Hits        74577    74593      +16     
+ Misses      14354    14344      -10     
Files with missing lines Coverage Δ
src/bindings/python/flux/job/Jobspec.py 89.92% <100.00%> (+0.06%) ⬆️
src/bindings/python/flux/cli/base.py 95.51% <50.00%> (-0.26%) ⬇️

... and 10 files with indirect coverage changes