kvs: remove fence support #6592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: In the near future the KVS fence implementation will be removed from the KVS. The only remaining user is the shell PMI plugin and its "native" KVS option. Solution: Remove all support for the native KVS in the shell pmi plugin. Remove associated documentation and tests.
Problem: In the near future the KVS fence implementation will be removed. So all KVS fence related tests will no longer be relevant. Solution: Remove all KVS fence related tests.
Problem: In the near future the KVS fence implementation will be removed. The flux_kvs_fence() function will no longer be applicable. Solution: Remove flux_kvs_fence().
Problem: The flux_kvs_fence(3) function has been removed but is still referenced in documentation. Remove all references to flux_kvs_fence(3).
Problem: The KVS fence implementation is virtually unused. It also has the potential for denial-of-service attacks. Its implementation is also quite "one off" within the KVS, limiting some ability to refactor the code. For all these reasons, it should be removed. If fence-like behavior is ever needed again in the future, it should be implemented as a stand alone module/service on top of the KVS. Solution: Remove all fence support in the KVS. Fixes flux-framework#6587
chu11
force-pushed
the
issue6587_kvs_fence_remove
branch
from
044238c to
5318a8d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6592 +/- ##
==========================================
- Coverage 79.46% 79.44% -0.02%
==========================================
Files 531 531
Lines 88433 88202 -231
==========================================
- Hits 70275 70075 -200
+ Misses 18158 18127 -31
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built upon the cleanups in #6591
Per discussion in #6112, remove KVS fence support.
Note that with this removal some refactoring of the KVS can happen, but I will leave that for a follow up PR. Making this simply the removal and nothing else.