kvs: report error to all fence requests #6583
Closed
+23
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: There is an errant typo in which an upper case example is written lower case. Make the example character upper case.
Problem: The very generic word "count" is used in the tool's usage and variable names. Update to "fence count" to make this more clear.
Problem: When an error occurs in a fence request, the error is only reported to the requestor. In most cases, this is fine, but the error should be reported to all members of the fence in some cases. Most notably, it should be reported to all members of the fence when the fence count has been reached and an error has occurred after this point. Solution: In fence_request_cb() return an error via the kvs function error_event_send_to_name() when it is appropriate.
|
closing, with #6587 removing fence support, this issue is no longer relevant |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6583 +/- ##
==========================================
- Coverage 79.48% 79.47% -0.02%
==========================================
Files 531 531
Lines 88421 88425 +4
==========================================
- Hits 70281 70272 -9
- Misses 18140 18153 +13
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: When an error occurs in a fence request, the error is
only reported to the requestor. In most cases, this is fine, but
the error should be reported to all members of the fence in some
cases. Most notably, it should be reported to all members of the
fence when the fence count has been reached and an error has
occurred after this point.
Solution: In fence_request_cb() return an error via
the kvs function error_event_send_to_name() when it is appropriate.
Spliting these few commits out of #6581 since it is an actual bug right now, no need to wait for #6581 to go in to fix it.