shell: generate fatal error if block taskmap scheme has an argument
#5730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: If --taskmap=block:foo is used, the job shell silently ignores the value 'foo'. This could lead to a job running with the wrong taskmap if the user intended some other taskmap scheme. It would be better to abort and notify the user something's wrong. Check if a value is specified with `--taskmap=block` and abort the shell if so.
Problem: None of the shell taskmap tests ensure that an argument specified with the block scheme is rejected by the shell. Add a test to t2616-job-shell-taskmap.t.
|
Thanks! |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5730 +/- ##
==========================================
- Coverage 83.46% 83.46% -0.01%
==========================================
Files 487 487
Lines 83130 83133 +3
==========================================
Hits 69385 69385
- Misses 13745 13748 +3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple PR fixes #5723: If a user inadvertently specifies
--taskmap=block:argwhen they meant--taskmap=other_scheme:arg, the shell currently silently ignoresargand silently continues with theblockscheme. Since an argument is not expected or allowed with theblocktaskmap scheme, the shell should generate an error in this case.Fixes #5723