broker: add FLUX_IPADDR_INTERFACE to select broker network interface #5707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garlick
changed the title
|
I added a test and removed WIP. |
grondo
approved these changes
Jan 29, 2024
garlick
force-pushed
the
ipaddr_interface
branch
from
a142c5e to
62104cc
Compare
|
Thanks! I got a test failure here in one builder: I wasn't sure if maybe setting the environment variable before a call to a shell function was perhaps not portable (the failure was in Ubunto 20.04)? So I pushed a small change to run the test in a subshell and export the variable within that subshell. (Now that I describe the problem and note the OS it seems doubful that this was the issue.... there may be something else going on? Let's see how it goes this time in CI) |
|
That test failure disappeared so I'll go ahead and set MWP. If it pops up again we can deal with it. |
Problem: there is no way to force a flux instance to use a specific network interface for overlay communication. Add an environment variable: FLUX_IPADDR_INTERFACE. If set to an interface name, that will select the preferred network.
Problem: FLUX_IPADDR_INTERFACE is not documented. Add it to the envrironment man page.
Problem: there is no test coverage for the FLUX_IPADDR_INTERFACE environment variable. Add a couple checks.
Problem: when ipaddr_getprimary() fails during PMI bootstrap, the broker prints the textual error plus, unnecessarily, the errno string. This results in messages like this: flux-broker: could not find address of badiface: Success Drop the errno string suffix.
garlick
force-pushed
the
ipaddr_interface
branch
from
62104cc to
fa4fdf5
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5707 +/- ##
==========================================
+ Coverage 83.44% 83.46% +0.01%
==========================================
Files 486 486
Lines 82892 82897 +5
==========================================
+ Hits 69170 69187 +17
+ Misses 13722 13710 -12
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: during scale testing, it was observed that Flux was using an unstable network fabric, but there is no way to tell it to use another one.
Add the FLUX_IPADDR_INTERFACE environment variable. It can be set to an interface name in the broker's environment, and then PMI bootstrap will select an address associated with that interface.