cli: avoid KeyError when PATH isn't set in environment #5590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5590 +/- ##
==========================================
- Coverage 83.45% 83.43% -0.03%
==========================================
Files 486 486
Lines 82450 82456 +6
==========================================
- Hits 68810 68798 -12
- Misses 13640 13658 +18
|
Problem: If PATH is not set in the environment of the flux-run(1) and flux-alloc(1) job submission commands, they raise an unhelpful KeyError and fail to invoke `flux job attach`, leaving the job running without the interactive attach. Do not assume PATH is set in these commands when prepending FLUX_EXEC_PATH. Fixes flux-framework#5562
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: If PATH is not set in the environment of the flux-run(1) and flux-alloc(1) job submission commands, they raise an unhelpful KeyError and fail to invoke
flux job attach, leaving the job running without the interactive attach.Do not assume PATH is set in these commands when prepending FLUX_EXEC_PATH.
Fixes #5562