Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: use a new URI format for flux-proxy #2747

Merged
merged 1 commit into from
Feb 15, 2020

Conversation

dongahn
Copy link
Member

@dongahn dongahn commented Feb 15, 2020

Problem: flux-proxy now requires "local" appended
to the end of the URI for both local and remote
connection, but the manpage still uses the old format.

Resolve Issue #2745.

@garlick
Copy link
Member

garlick commented Feb 15, 2020

Oh I didn't see this! I'll drop this patch from the PR I just submitted.

Copy link
Member

@SteVwonder SteVwonder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @dongahn!

Problem: flux-proxy now requires "local" appended
to the end of the URI for both local and remote
connection, but the manpage still uses the old format.
@mergify mergify bot merged commit 6918a51 into flux-framework:master Feb 15, 2020
@codecov-io
Copy link

Codecov Report

Merging #2747 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2747      +/-   ##
==========================================
+ Coverage   81.44%   81.47%   +0.02%     
==========================================
  Files         248      248              
  Lines       39025    39025              
==========================================
+ Hits        31784    31795      +11     
+ Misses       7241     7230      -11
Impacted Files Coverage Δ
src/modules/job-info/watch.c 72.53% <0%> (+1.55%) ⬆️
src/common/libpmi/pmi.c 93.39% <0%> (+1.88%) ⬆️
src/common/libpmi/simple_client.c 89.61% <0%> (+3.27%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants