[WIP] export-db: allow formatting customization of association_table and bank_table
#529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: The export_db_info() function statically defines the columns extracted from both the bank_table and the association_table, but there could definitely be a case where the user extracting DB information wants to customize the format of the data they are retrieving. Refactor the export_db_info() function to allow customization of which fields to extract from both association_table and bank_table through optional arguments. Dynamically build each SQLite query using these custom fields and include which columns are being used in the header of the .csv files.
Problem: Now that export-db can format custom output and includes a header, the pop-db command should expect a header when populating the DB with user and bank information. Add skips of the both the banks .csv files and users .csv files when reading from them.
Problem: The tests for the pop-db and export-db commands are outdated with the improvements made to export_db_info() - namely, the inclusion of headers in the .csv file & the customization of output. Adjust the tests in t1009-pop-db.t and t1016-export-db.t to account for the changes made to export_db_info().
cmoussa1
added
improvement
cmoussa1
changed the title
export-db: allow formatting customization of association_table and bank_table
cmoussa1
changed the title
export-db: allow formatting customization of association_table and bank_tableexport-db: allow formatting customization of association_table and bank_table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
export_db_info()function statically defines the columns extracted from both thebank_tableand theassociation_table, but there could definitely be a case where the user extracting DB information wants to customize the format of the data they are retrieving.This PR refactors the
export_db_info()function to allow customization of which fields to extract from bothassociation_tableandbank_tablethrough optional arguments. It dynamically builds each SQLite query using thesecustom fields and includes which columns are being used in the header of the
.csvfiles.I've adjusted the
populate_db()function as well as the tests for both thepop-dbandexport-dbcommands to account for the adjustments toexport_db_info()- namely, skipping the headers of the.csvfiles and including custom formatting in theexport-dbcalls.