view_jobs(): adjust helper function to actually return a string
#522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmoussa1
added
improvement
|
Thanks! Setting MWP here |
Problem: The convert_to_str() function used to convert a list of JobRecord objects to a string does not actually convert it to a string, but rather just appends separate strings to a list and then returns a list. Thus, flux-account.py has to have some special logic for just the view-job-records command to parse the returned data from the function. Add a .join() call to the convert_to_str() function to actually construct a string of all of the job records returned by view_jobs(). Remove the special logic in flux-account.py that iterates through the list of job records and prints it out since it is no longer needed.
Problem: The unit tests for jobs_table_subcommands.py use view_jobs() for checking the correct amount of job records returned, but get_jobs() is a better function to call here since it returns a list. Convert the view_jobs() calls to get_jobs() in the unit tests in t1006_job_archive.py. Since the return value of get_jobs() does not include the headers for the job records, reduce all of the expected lengths of job record lists by 1.
Problem: One of the descriptions of one of the unit tests in t1006_job_archive.py is incorrectly stating that one of the function calls should raise an error, but this is not the case; it should just return a list of length 0. Adjust the test description to more accurately explain what the expected behavior is.
cmoussa1
force-pushed
the
adjust.view-job-records
branch
from
8f7badb
to
443c282
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
convert_to_str()function used to convert a list ofJobRecordobjects to a string does not actually convert it to a string, but rather just appends separate strings to a list and then returns a list. Thus,flux-account.pyhas to have some special logic for just theview-job-recordscommand to parse the returned data from the function.This PR adds a
.join()call to theconvert_to_str()function to actually construct a string of all of the job records returned byview_jobs(). It also removes the special logic influx-account.pythat iterates through the list of job records and prints it out since it is no longer needed. I've also adjusted the unit tests int1006_job_archive.pyto use a better function injobs_table_subcommands.py, as well as fixed a test description for one of the unit tests.