[WIP] Create minimal self-contained instrumentation pass #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not properly tested but should have "all" the parts to work with various LLVM versions. No need for bison/flex anymore, parsing is done in the pass. No header anymore, that was never needed. LLVM coding style. Tested successfully with some clang versions. Needs more testing.
jdoerfert
commented
Oct 11, 2024
| @@ -1,5 +1,5 @@ | |||
| # support C++14 features used by LLVM 10.0.0 | |||
| set(CMAKE_CXX_STANDARD 14) | |||
| set(CMAKE_CXX_STANDARD 17) | |||
There was a problem hiding this comment.
This should be determined based on the LLVM version used to compile the plugin. Basically, use whatever was the development default in that LLVM version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not properly tested but should have "all" the parts to work with various LLVM versions. No need for bison/flex anymore, parsing is done in the pass. No header anymore, that was never needed. LLVM coding style. Tested successfully with some clang versions.
Needs more testing.