Bump cocoapods from 1.10.1 to 1.12.1 in /dev/ci/mac #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [cocoapods](https://github.com/CocoaPods/CocoaPods) from 1.10.1 to 1.12.1. - [Release notes](https://github.com/CocoaPods/CocoaPods/releases) - [Changelog](https://github.com/CocoaPods/CocoaPods/blob/master/CHANGELOG.md) - [Commits](CocoaPods/CocoaPods@1.10.1...1.12.1) --- updated-dependencies: - dependency-name: cocoapods dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
|
Dependabot tried to add |
|
The following labels could not be found: |
Hixie
pushed a commit
that referenced
this pull request
Sep 12, 2023
This is a follow up to the following pull requests: - flutter#124514 I was finally able to reproduce this bug and found out why it was happening. Consider this code: ```dart GestureDetector( behavior: HitTestBehavior.translucent, // Note: Make sure onTap is not null to ensure events // are captured by `GestureDetector` onTap: () {}, child: _shouldShowSlider ? Slider(value: _value, onChanged: _handleSlide) : const SizedBox.shrink(). ) ``` Runtime exception happens when: 1. User taps and holds the Slider (drag callback captured by `GestureDetector`) 2. `_shouldShowSlider` changes to false, Slider disappears and unmounts, and unregisters `_handleSlide`. But the callback is still registered by `GestureDetector` 3. Users moves finger as if Slider were still there 4. Drag callback is invoked, `_SliderState.showValueIndicator` is called 5. Exception - Slider is already disposed This pull request fixes it by adding a mounted check inside `_SliderState.showValueIndicator` to ensure the Slider is actually mounted at the time of invoking drag event callback. I've added a unit test that will fail without this change. The error stack trace is: ``` The following assertion was thrown while handling a gesture: This widget has been unmounted, so the State no longer has a context (and should be considered defunct). Consider canceling any active work during "dispose" or using the "mounted" getter to determine if the State is still active. When the exception was thrown, this was the stack: #0 State.context.<anonymous closure> (package:flutter/src/widgets/framework.dart:950:9) #1 State.context (package:flutter/src/widgets/framework.dart:956:6) #2 _SliderState.showValueIndicator (package:flutter/src/material/slider.dart:968:18) #3 _RenderSlider._startInteraction (package:flutter/src/material/slider.dart:1487:12) flutter#4 _RenderSlider._handleDragStart (package:flutter/src/material/slider.dart:1541:5) flutter#5 DragGestureRecognizer._checkStart.<anonymous closure> (package:flutter/src/gestures/monodrag.dart:531:53) flutter#6 GestureRecognizer.invokeCallback (package:flutter/src/gestures/recognizer.dart:275:24) flutter#7 DragGestureRecognizer._checkStart (package:flutter/src/gestures/monodrag.dart:531:7) flutter#8 DragGestureRecognizer._checkDrag (package:flutter/src/gestures/monodrag.dart:498:5) flutter#9 DragGestureRecognizer.acceptGesture (package:flutter/src/gestures/monodrag.dart:431:7) flutter#10 _CombiningGestureArenaMember.acceptGesture (package:flutter/src/gestures/team.dart:45:14) flutter#11 GestureArenaManager._resolveInFavorOf (package:flutter/src/gestures/arena.dart:281:12) flutter#12 GestureArenaManager._resolve (package:flutter/src/gestures/arena.dart:239:9) flutter#13 GestureArenaEntry.resolve (package:flutter/src/gestures/arena.dart:53:12) flutter#14 _CombiningGestureArenaMember._resolve (package:flutter/src/gestures/team.dart:85:15) flutter#15 _CombiningGestureArenaEntry.resolve (package:flutter/src/gestures/team.dart:19:15) flutter#16 OneSequenceGestureRecognizer.resolve (package:flutter/src/gestures/recognizer.dart:375:13) flutter#17 DragGestureRecognizer.handleEvent (package:flutter/src/gestures/monodrag.dart:414:13) flutter#18 PointerRouter._dispatch (package:flutter/src/gestures/pointer_router.dart:98:12) flutter#19 PointerRouter._dispatchEventToRoutes.<anonymous closure> (package:flutter/src/gestures/pointer_router.dart:143:9) flutter#20 _LinkedHashMapMixin.forEach (dart:collection-patch/compact_hash.dart:625:13) flutter#21 PointerRouter._dispatchEventToRoutes (package:flutter/src/gestures/pointer_router.dart:141:18) flutter#22 PointerRouter.route (package:flutter/src/gestures/pointer_router.dart:127:7) flutter#23 GestureBinding.handleEvent (package:flutter/src/gestures/binding.dart:488:19) flutter#24 GestureBinding.dispatchEvent (package:flutter/src/gestures/binding.dart:468:22) flutter#25 RendererBinding.dispatchEvent (package:flutter/src/rendering/binding.dart:439:11) flutter#26 GestureBinding._handlePointerEventImmediately (package:flutter/src/gestures/binding.dart:413:7) flutter#27 GestureBinding.handlePointerEvent (package:flutter/src/gestures/binding.dart:376:5) flutter#28 GestureBinding._flushPointerEventQueue (package:flutter/src/gestures/binding.dart:323:7) flutter#29 GestureBinding._handlePointerDataPacket (package:flutter/src/gestures/binding.dart:292:9) flutter#30 _invoke1 (dart:ui/hooks.dart:186:13) flutter#31 PlatformDispatcher._dispatchPointerDataPacket (dart:ui/platform_dispatcher.dart:433:7) flutter#32 _dispatchPointerDataPacket (dart:ui/hooks.dart:119:31) Handler: "onStart" Recognizer: HorizontalDragGestureRecognizer#a5df2 ``` *List which issues are fixed by this PR. You must list at least one issue.* Internal bug: b/273666179, b/192329942 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
Hixie
pushed a commit
that referenced
this pull request
Sep 19, 2023
fluttergithubbot
pushed a commit
that referenced
this pull request
Aug 21, 2024
When attempting to release the Flutter 3.24.1 hotfix, Flutter framework post submits failed due to the following error: ``` ���ERROR #1��������������������������������������������������������������������� � UNEXPECTED ERROR! � Exception: Found unexpected binary in cache: /Volumes/Work/s/w/ir/x/w/flutter/bin/cache/artifacts/engine/ios-release/extension_safe/Flutter.xcframework/ios-arm64_x86_64-simulator/dSYMs/Flutter.framework.dSYM/Contents/Resources/DWARF/Flutter � #0 verifyExist (file:///Volumes/Work/s/w/ir/x/w/flutter/dev/bots/suite_runners/run_verify_binaries_codesigned_tests.dart:150:12) � <asynchronous suspension> � #1 verifyCodesignedTestRunner (file:///Volumes/Work/s/w/ir/x/w/flutter/dev/bots/suite_runners/run_verify_binaries_codesigned_tests.dart:28:3) � <asynchronous suspension> � #2 _runFromList (file:///Volumes/Work/s/w/ir/x/w/flutter/dev/bots/utils.dart:601:5) � <asynchronous suspension> � #3 main (file:///Volumes/Work/s/w/ir/x/w/flutter/dev/bots/test.dart:125:5) � <asynchronous suspension> � � The test.dart script should be corrected to catch this error and call foundError(). � Some tests are likely to have been skipped. �������������������������������������������������������������������������������� ``` I've updated the tests to include the listed artifact. ### Open questions 1. Is it possible that the test failed only on the first binary? 2. Do we expect a need to add the remainder of the [entitlement changes](flutter/engine@c9b9d57)? 3. I am under the assumption that the bots pull from master and are not branch specific, is this a correct assumption? CC @christopherfujino @cbracken
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps cocoapods from 1.10.1 to 1.12.1.
Release notes
Sourced from cocoapods's releases.
... (truncated)
Changelog
Sourced from cocoapods's changelog.
... (truncated)
Commits
7de7463Release 1.12.1e7f7ad4Changelog spacing5c0e879Update changelog20e3a86Fix typo in validation716c78bTwo spacesfea7b5eupdate testsa5a8387Xcode 14.3 fix: pod lib lint warning generation from main.m.b3e70a3Update integration specs136095dUpdate integrations spec43a9de1Add an entry to changelog.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)