Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: loosen dependency constraint to support package_info_plus v8 and v9 #52

Merged

Conversation

josxha
Copy link
Contributor

@josxha josxha commented Apr 25, 2024

Changes

This pull request loosens the constraint to support v6, v7 and v8 of package_info_plus.

Description

The latest version of package_info_plus is 8.0.0 while the constraint in wakelock_plus is set to <8.0.0.
There is only one breaking change in package_info_plus that wakelock_plus:

BREAKING FEAT(package_info_plus): Switch to SHA-256 for buildSignature on Android

package_info_plus isn't affected by this breaking change because the only usage is appName in wakelock_plus_linux_plugin.dart.

latest version of package_info_plus is 9.0.0
@diegotori
Copy link
Collaborator

@josxha thanks for your PR. Once the tests go green, then I'll approve.

Since I'm currently out of the country, I'll be able to deploy a new build on Tuesday the earliest.

In the meantime, you can add a dependency override to this new package_info_plus version in your pubspec.

@josxha
Copy link
Contributor Author

josxha commented Apr 29, 2024

Thanks for your response @diegotori! I tried to look into the failed CI. I don't think that there isn't really a problem and they just ran into a timeout that one time.
Althrough, I can't really debug the workflows while they need manual approval to run. But all tests went trhough successfully when I triggered them in my fork.

@mrwebbeast
Copy link

Hi Guys any updates on this

Copy link
Collaborator

@diegotori diegotori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@diegotori diegotori merged commit d0abded into fluttercommunity:main May 3, 2024
14 checks passed
@diegotori diegotori mentioned this pull request May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need the dependency for package_info_plus to be <= 8.0.0 not < 8.0.0
5 participants