Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SystemUUID.swift #3258

Closed
wants to merge 1 commit into from

Conversation

fmatuszewski
Copy link

Fix For older Maxos platforms.
#available(macOS 12, *) is not available on runtime for older platforms it must be replaced by Compiletime directive #if MACOS12_OR_LATER

Description

I have an older laptop and I can't compile this code because if #available(macOS 12, *) { this function is not available on older mac platforms. Ater I replaced it with compile time directive it start to works.

Fix For older Maxos platforms.
#available(macOS 12, *) is not available on runtime for older platforms it must be replaced by Compiletime directive
#if MACOS12_OR_LATER
Copy link

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Update SystemUUID.swift". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@miquelbeltran
Copy link
Member

Hello. I am not sure this change is correct, you are changing a runtime OS version check by a compilation flag.

As I understand, if you compile the code on an older machine and deploy it to a modern machine, it will break because it will use kIOMasterPortDefault when it should be using kIOMainPortDefault. And the same the other way around.

@vbuberen
Copy link
Collaborator

vbuberen commented Sep 18, 2024

I would appreciate if you check the provided PR template and fill in info as well as read contributors guide and name the PR properly. Respect other people's time.

@miquelbeltran
Copy link
Member

Closing since no follow up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants