Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(device_info_plus): Add Swift Package Manager support #3167

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

charafau
Copy link
Contributor

@charafau charafau commented Aug 9, 2024

ref: #3152

Since SPM support is comming I plan to add it to all plugins.

Followed the guide - https://docs.flutter.dev/packages-and-plugins/swift-package-manager/for-plugin-authors
and checked it for both cocoapods and spm

@charafau charafau changed the title [Device Info] Add Swift Package Manager support for Device info feat: [Device Info] Add Swift Package Manager support for Device info Aug 9, 2024
Copy link
Member

@miquelbeltran miquelbeltran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not super familiar with the process yet, but took a look at it, and left some comments.

Also, we should do the same for the macOS part of the project, right? In that case, we should indicate in the Title that this only covers iOS

@charafau
Copy link
Contributor Author

I am not super familiar with the process yet, but took a look at it, and left some comments.

Also, we should do the same for the macOS part of the project, right? In that case, we should indicate in the Title that this only covers iOS

Thanks for fast review, this is also my first time doing it. I will apply suggestions from you and @koji-1009 and upload today. Hopefully migrate all plugins

@charafau
Copy link
Contributor Author

Thanks guys, should be good now. I also added support for macos

@miquelbeltran miquelbeltran changed the title feat: [Device Info] Add Swift Package Manager support for Device info feat(device_info_plus): Add Swift Package Manager support for Device info Aug 12, 2024
@miquelbeltran
Copy link
Member

miquelbeltran commented Aug 12, 2024

Please take a look at the macos CI jobs, as they are now failing.

@vbuberen vbuberen changed the title feat(device_info_plus): Add Swift Package Manager support for Device info feat(device_info_plus): Add Swift Package Manager support Aug 13, 2024
@charafau
Copy link
Contributor Author

Please take a look at the macos CI jobs, as they are now failing.

Sorry didn't notice that it's a scrollable list 😅 fixed and is passing now

Adjust whitespaces

Co-authored-by: Loïc Sharma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants