fix(Android): show blank icon if no adaptive icon set #601
+10
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @OutdatedGuy, could you help take a look at this? |
chungxon
added a commit
to chungxon/flutter_app_customizer
that referenced
this pull request
Oct 13, 2024
|
Can confirm it works. Specifying |
OutdatedGuy
approved these changes
Nov 11, 2024
There was a problem hiding this comment.
LGTM!
However, I'm not a maintainer. @MarkOSullivan94 can you have a look?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #578, #579, #585, #589, #594, #595, #600
In the new version 0.14.1, not everyone specified
adaptive_icon_backgroundandadaptive_icon_foregroundoradaptive_icon_monochromein their Android configuration, so the app icon may be black/blank after generating.As suggested by #579 (comment), you can delete the
android/app/src/main/res/mipmap-anydpi-v26/${androidIconName}.xmlfile after running generating to solve this issue.However, it will still always create this file. I think this file should only be created if any configuration related to adaptive icons is set up.